Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10031)

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.h

Issue 2230053002: [chromedriver] Added option to make element references W3C compliant. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased code with w3c flag change. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/web_view_impl.h
diff --git a/chrome/test/chromedriver/chrome/web_view_impl.h b/chrome/test/chromedriver/chrome/web_view_impl.h
index b326c4617d6ae1055f29e2b593da27f64d00baa2..a8d21681ca63d07f38ae3393ef057f465842fdb9 100644
--- a/chrome/test/chromedriver/chrome/web_view_impl.h
+++ b/chrome/test/chromedriver/chrome/web_view_impl.h
@@ -40,12 +40,10 @@ class WebViewImpl : public WebView {
public:
WebViewImpl(const std::string& id,
const BrowserInfo* browser_info,
- std::unique_ptr<DevToolsClient> client);
- WebViewImpl(const std::string& id,
- const BrowserInfo* browser_info,
std::unique_ptr<DevToolsClient> client,
const DeviceMetrics* device_metrics,
- std::string page_load_strategy);
+ std::string page_load_strategy,
+ const bool w3c_compliant);
~WebViewImpl() override;
// Overridden from WebView:
@@ -111,6 +109,7 @@ class WebViewImpl : public WebView {
int xoffset,
int yoffset) override;
Status SynthesizePinchGesture(int x, int y, double scale_factor) override;
+ //void SetW3CCompliant(const bool w3c_compliant) override;
samuong 2016/08/11 18:13:20 delete this line?
roisinmcl 2016/08/13 01:47:26 Done.
private:
Status TraverseHistoryWithJavaScript(int delta);
@@ -128,6 +127,7 @@ class WebViewImpl : public WebView {
Status StopProfileInternal();
std::string id_;
+ bool w3c_compliant_;
const BrowserInfo* browser_info_;
std::unique_ptr<DomTracker> dom_tracker_;
std::unique_ptr<FrameTracker> frame_tracker_;
@@ -170,7 +170,8 @@ Status GetNodeIdFromFunction(DevToolsClient* client,
const std::string& function,
const base::ListValue& args,
bool* found_node,
- int* node_id);
+ int* node_id,
+ bool w3c_compliant);
} // namespace internal

Powered by Google App Engine
This is Rietveld 408576698