chrome/test/chromedriver/chrome/devtools_http_client.cc - Issue 2230053002: [chromedriver] Added option to make element references W3C compliant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client.cc

Issue 2230053002: [chromedriver] Added option to make element references W3C compliant. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased code with w3c flag change. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_impl.cc ('k') | chrome/test/chromedriver/chrome/web_view_impl.h » ('j') | chrome/test/chromedriver/chrome/web_view_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/devtools_http_client.cc

diff --git a/chrome/test/chromedriver/chrome/devtools_http_client.cc b/chrome/test/chromedriver/chrome/devtools_http_client.cc

index 34023aeb18344c24b923324196ed3bd30be1e58b..2b4f32da88afe9229fb970b3dab100b9ea20e1cb 100644

--- a/chrome/test/chromedriver/chrome/devtools_http_client.cc

+++ b/chrome/test/chromedriver/chrome/devtools_http_client.cc

@@ -206,7 +206,7 @@ Status DevToolsHttpClient::CloseFrontends(const std::string& for_client_id) {

socket_factory_, web_socket_url_prefix_ + *it, *it));

std::unique_ptr<WebViewImpl> web_view(

new WebViewImpl(*it, &browser_info_, std::move(client), NULL,

- page_load_strategy_));

+ page_load_strategy_, false));

status = web_view->ConnectIfNecessary();

// Ignore disconnected error, because the debugger might have closed when