chrome/test/chromedriver/chrome/chrome_impl.cc - Issue 2230053002: [chromedriver] Added option to make element references W3C compliant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.cc

Issue 2230053002: [chromedriver] Added option to make element references W3C compliant. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased code with w3c flag change. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_impl.h ('k') | chrome/test/chromedriver/chrome/devtools_http_client.cc » ('j') | chrome/test/chromedriver/chrome/web_view_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/chrome_impl.cc

diff --git a/chrome/test/chromedriver/chrome/chrome_impl.cc b/chrome/test/chromedriver/chrome/chrome_impl.cc

index 8c18185e4bb717264de01b189b020d1b1f95db9a..1ecdb3dd46e093389014fbb1cc40b5cdbf242828 100644

--- a/chrome/test/chromedriver/chrome/chrome_impl.cc

+++ b/chrome/test/chromedriver/chrome/chrome_impl.cc

@@ -37,7 +37,8 @@ bool ChromeImpl::HasCrashedWebView() {

return false;

}

-Status ChromeImpl::GetWebViewIds(std::list<std::string>* web_view_ids) {

+Status ChromeImpl::GetWebViewIds(std::list<std::string>* web_view_ids,

+ bool w3c_compliant) {

WebViewsInfo views_info;

Status status = devtools_http_client_->GetWebViewsInfo(&views_info);

if (status.IsError())

@@ -79,7 +80,8 @@ Status ChromeImpl::GetWebViewIds(std::list<std::string>* web_view_ids) {

}

web_views_.push_back(make_linked_ptr(new WebViewImpl(

view.id, devtools_http_client_->browser_info(), std::move(client),

- devtools_http_client_->device_metrics(), page_load_strategy_)));

+ devtools_http_client_->device_metrics(),

+ page_load_strategy_, w3c_compliant)));

}