Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2230043002: Make test-results upload URL configurable. (Closed)

Created:
4 years, 4 months ago by jbudorick
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Make test-results upload URL configurable. and also make the chromium.android testers upload to their gtest results to test-results. BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/cde40737c6fdc82d5923314b858aee7af9413aed

Patch Set 1 #

Patch Set 2 : prereview: 80 chars #

Patch Set 3 : prereview: -TODO #

Patch Set 4 : rebase #

Total comments: 4

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -34 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_android.py View 13 chunks +13 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/test_results/api.py View 1 2 3 chunks +8 lines, -11 lines 0 comments Download
A scripts/slave/recipe_modules/test_results/config.py View 1 chunk +19 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.py View 1 2 3 4 1 chunk +18 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/dynamic_gtest_android.json View 1 2 3 4 10 chunks +15 lines, -23 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
jbudorick
4 years, 4 months ago (2016-08-10 00:38:31 UTC) #2
jbudorick
On 2016/08/10 00:38:31, jbudorick wrote: This is intentionally limited in scope. I'm planning on landing ...
4 years, 4 months ago (2016-08-10 00:39:48 UTC) #3
martiniss
lgtm
4 years, 4 months ago (2016-08-10 00:44:27 UTC) #4
estaab
lgtm
4 years, 4 months ago (2016-08-10 01:19:05 UTC) #5
ghost stip (do not use)
rs-lgtm
4 years, 4 months ago (2016-08-10 19:10:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230043002/40001
4 years, 4 months ago (2016-08-10 19:11:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/308eafe1c1479c10)
4 years, 4 months ago (2016-08-10 19:14:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230043002/60001
4 years, 4 months ago (2016-08-10 19:34:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/308ec490ac669b10)
4 years, 4 months ago (2016-08-10 19:42:35 UTC) #15
jbudorick
+dpranke for recipes/chromium.py owners.
4 years, 4 months ago (2016-08-10 19:44:01 UTC) #17
Dirk Pranke
lgtm w/ nit/question. https://codereview.chromium.org/2230043002/diff/60001/scripts/slave/recipe_modules/chromium_tests/steps.py File scripts/slave/recipe_modules/chromium_tests/steps.py (right): https://codereview.chromium.org/2230043002/diff/60001/scripts/slave/recipe_modules/chromium_tests/steps.py#newcode359 scripts/slave/recipe_modules/chromium_tests/steps.py:359: 'got_revision_cp', 'x@{#0}')) should we just accept ...
4 years, 4 months ago (2016-08-11 00:11:53 UTC) #18
jbudorick
https://codereview.chromium.org/2230043002/diff/60001/scripts/slave/recipe_modules/chromium_tests/steps.py File scripts/slave/recipe_modules/chromium_tests/steps.py (right): https://codereview.chromium.org/2230043002/diff/60001/scripts/slave/recipe_modules/chromium_tests/steps.py#newcode359 scripts/slave/recipe_modules/chromium_tests/steps.py:359: 'got_revision_cp', 'x@{#0}')) On 2016/08/11 00:11:53, Dirk Pranke wrote: > ...
4 years, 4 months ago (2016-08-11 02:45:48 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230043002/80001
4 years, 4 months ago (2016-08-15 14:31:17 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 14:35:21 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/tools/build/+/cde40737c6fdc82d5923...

Powered by Google App Engine
This is Rietveld 408576698