Make test-results upload URL configurable.

scripts/slave/recipe_modules/chromium_tests/steps.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import re
 import string
 
 
 class Test(object):
@@ skipping 333 matching lines @@
 
       if hasattr(step_result, 'test_utils'):
         r = step_result.test_utils.gtest_results
         p = step_result.presentation
 
         if r.valid:
           p.step_text += api.test_utils.format_step_text([
             ['failures:', r.failures]
           ])
 
+        if api.test_results.c.test_results_server:
+          api.test_results.upload(
+              api.json.input(r.raw),
+              test_type=self.name,
+              chrome_revision=api.bot_update.last_returned_properties.get(
+                  'got_revision_cp', 'x@{#0}'))

[Dirk Pranke, 2016/08/11 00:11:53]

should we just accept the exception here if the key is missing?

[jbudorick, 2016/08/11 02:45:48]

I'm not sure, but this is what we're doing in the other call sites in this
module.

+
+
     return step_result
 
   def has_valid_results(self, api, suffix):
     if suffix not in self._test_runs:
       return False  # pragma: no cover
     if not hasattr(self._test_runs[suffix], 'test_utils'):
       return False  # pragma: no cover
     gtest_results = self._test_runs[suffix].test_utils.gtest_results
     if not gtest_results.valid:  # pragma: no cover
       return False
@@ skipping 542 matching lines @@
     finally:
       step_result = api.step.active_result
       # Only upload test results if we have gtest results.
       if (self._upload_test_results and
           hasattr(step_result, 'test_utils') and
           hasattr(step_result.test_utils, 'gtest_results')):
         gtest_results = getattr(step_result.test_utils, 'gtest_results', None)
         if gtest_results and gtest_results.raw:
           parsed_gtest_data = gtest_results.raw
           chrome_revision_cp = api.bot_update.last_returned_properties.get(
               'got_revision_cp', 'x@{#0}')

[jbudorick, 2016/08/11 02:45:48]

i.e., here

           chrome_revision = str(api.commit_position.parse_revision(
               chrome_revision_cp))
           api.test_results.upload(
               api.json.input(parsed_gtest_data),
               chrome_revision=chrome_revision,
               test_type=step_result.step['name'],
               test_results_server='test-results.appspot.com')
 
 
 class LocalIsolatedScriptTest(Test):
@@ skipping 428 matching lines @@
 
         failures = gtest_results.failures
         self._test_runs[suffix] = {'valid': True, 'failures': failures}
         step_result.presentation.step_text += (
             api.test_utils.format_step_text([['failures:', failures]]))
 
         api.test_results.upload(
             api.json.input(gtest_results.raw),
             test_type=self.name,
             chrome_revision=api.bot_update.last_returned_properties.get(
                 'got_revision_cp', 'x@{#0}'),

[jbudorick, 2016/08/11 02:45:47]

and here

             test_results_server='test-results.appspot.com')
 
   def compile_targets(self, _):
     return self._compile_targets
 
   def has_valid_results(self, api, suffix):
     if suffix not in self._test_runs:
       return False  # pragma: no cover
     return self._test_runs[suffix]['valid']
 
@@ skipping 361 matching lines @@
           args=args)
       api.gsutil.upload(
           temp_output_dir.join(
               '%s-android-chrome.json' % timestamp_string),
           'chromium-annotated-tests', 'android')
 
 GOMA_TESTS = [
   GTestTest('base_unittests'),
   GTestTest('content_unittests'),
 ]