content/renderer/pepper/pepper_broker.h - Issue 22300003: Move broker creation out of PepperHelperImpl to PPB_Broker_Impl in the effort to eliminate PepperHe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_broker.h

Issue 22300003: Move broker creation out of PepperHelperImpl to PPB_Broker_Impl in the effort to eliminate PepperHe… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_message_filter.cc ('K') | « content/common/view_messages.h ('k') | content/renderer/pepper/pepper_broker.cc » ('j') | content/renderer/pepper/ppb_broker_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_broker.h

===================================================================

--- content/renderer/pepper/pepper_broker.h (revision 215720)

+++ content/renderer/pepper/pepper_broker.h (working copy)

@@ -24,7 +24,6 @@

namespace content {

-class PepperHelperImpl;

class PluginModule;

// This object is NOT thread-safe.

@@ -46,7 +45,7 @@

class PepperBroker : public base::RefCountedThreadSafe<PepperBroker>{

public:

- PepperBroker(PluginModule* plugin_module, PepperHelperImpl* helper);

+ explicit PepperBroker(PluginModule* plugin_module);

// Decrements the references to the broker.

// When there are no more references, this renderer's dispatcher is

@@ -97,8 +96,6 @@

// Always set and cleared at the same time as the module's pointer to this.

PluginModule* plugin_module_;

- base::WeakPtr<PepperHelperImpl> helper_;

DISALLOW_COPY_AND_ASSIGN(PepperBroker);

};