Move broker creation out of PepperHelperImpl to PPB_Broker_Impl in the effort to eliminate PepperHe…

content/browser/renderer_host/render_message_filter.cc

Index: content/browser/renderer_host/render_message_filter.cc
===================================================================
--- content/browser/renderer_host/render_message_filter.cc	(revision 215720)
+++ content/browser/renderer_host/render_message_filter.cc	(working copy)
@@ -171,11 +171,9 @@
     : public PpapiPluginProcessHost::BrokerClient {
  public:
   OpenChannelToPpapiBrokerCallback(RenderMessageFilter* filter,
-                                   int routing_id,
-                                   int request_id)
+                                   int routing_id)
       : filter_(filter),
-        routing_id_(routing_id),
-        request_id_(request_id) {
+        routing_id_(routing_id) {
   }
 
   virtual ~OpenChannelToPpapiBrokerCallback() {}
@@ -188,9 +186,8 @@
 
   virtual void OnPpapiChannelOpened(const IPC::ChannelHandle& channel_handle,
                                     base::ProcessId plugin_pid,
-                                    int /* plugin_child_id */) OVERRIDE {
+                                    int plugin_child_id) OVERRIDE {

[dmichael (off chromium), 2013/08/06 18:43:31]

nit: I'd prefer you left it commented out if it's still unused.

[jam, 2013/08/06 19:34:09]

this isn't really a pattern that we use in chrome code. but i'll change it back
cause i'm just applying my preference to existing code

     filter_->Send(new ViewMsg_PpapiBrokerChannelCreated(routing_id_,
-                                                        request_id_,
                                                         plugin_pid,
                                                         channel_handle));
     delete this;
@@ -203,7 +200,6 @@
  private:
   scoped_refptr<RenderMessageFilter> filter_;
   int routing_id_;
-  int request_id_;
 };
 
 }  // namespace
@@ -788,12 +784,11 @@
 
 void RenderMessageFilter::OnOpenChannelToPpapiBroker(
     int routing_id,
-    int request_id,
     const base::FilePath& path) {
   plugin_service_->OpenChannelToPpapiBroker(
       render_process_id_,
       path,
-      new OpenChannelToPpapiBrokerCallback(this, routing_id, request_id));
+      new OpenChannelToPpapiBrokerCallback(this, routing_id));
 }
 
 void RenderMessageFilter::OnGenerateRoutingID(int* route_id) {