Support for custom primaries

Support for custom primaries

When converting an ICC profile to a ColorSpace, the primaries are extracted.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/24f935a3d8cdfcdfbabd23928a42304b1ffc52ba
Committed: https://crrev.com/1ae106dbab4bddd85132d5b75c670794311f4c57
Cr-Original-Commit-Position: refs/heads/master@{#413914}
Cr-Commit-Position: refs/heads/master@{#414607}

[hubbe, 2016-08-10 00:16:40]

hubbe@chromium.org changed reviewers:
+ ccameron@chromium.org

[hubbe, 2016-08-10 19:22:21]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 19:22:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 20:08:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 20:08:36]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[hubbe, 2016-08-10 20:38:21]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 20:39:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 22:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 22:38:24]

Dry run: This issue passed the CQ dry run.

[hubbe, 2016-08-11 23:37:13]

Description was changed from

==========
Support for custom primaries

When converting an ICC profile to a ColorSpace, the primaries are extracted.
==========

to

==========
Support for custom primaries

When converting an ICC profile to a ColorSpace, the primaries are extracted.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[hubbe, 2016-08-11 23:37:24]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 23:38:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 23:50:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 23:50:39]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[hubbe, 2016-08-12 16:53:18]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 16:53:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 17:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 17:17:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hubbe, 2016-08-12 17:20:59]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 17:21:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 18:16:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 18:16:31]

Dry run: This issue passed the CQ dry run.

[hubbe, 2016-08-12 18:24:43]

On 2016/08/10 00:16:41, hubbe wrote:

PING

Although, I'm wondering if we should encapsulate the custom primaries and custom
transfer functions into refcounted "custom colorspace" class?

[ccameron, 2016-08-12 19:09:58]

On 2016/08/12 18:24:43, hubbe wrote:
> On 2016/08/10 00:16:41, hubbe wrote:
> 
> PING

Sorry!!

> Although, I'm wondering if we should encapsulate the custom primaries and
custom
> transfer functions into refcounted "custom colorspace" class?

I think we should wait on that. I had that "internal ICC" stuff earlier, and it
wasn't worth the hassle.

[ccameron, 2016-08-18 00:13:56]

On 2016/08/12 19:09:58, ccameron (slow til Sept 1) wrote:
> On 2016/08/12 18:24:43, hubbe wrote:
> > On 2016/08/10 00:16:41, hubbe wrote:
> > 
> > PING
> 
> Sorry!!
> 
> > Although, I'm wondering if we should encapsulate the custom primaries and
> custom
> > transfer functions into refcounted "custom colorspace" class?
> 
> I think we should wait on that. I had that "internal ICC" stuff earlier, and
it
> wasn't worth the hassle.

Ugh, and I forgot to put the lgtm. Sorry again.

[hubbe, 2016-08-18 00:29:11]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2016-08-18 00:29:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 00:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 00:37:59]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hubbe, 2016-08-18 22:03:27]

hubbe@chromium.org changed reviewers:
+ tsepez@chromium.org

[hubbe, 2016-08-18 22:03:27]

+ tsepez for IPC security review

[Tom Sepez, 2016-08-18 22:13:18]

IPC LGTM.

https://codereview.chromium.org/2229953003/diff/100001/ui/gfx/ipc/color/gfx_p...
File ui/gfx/ipc/color/gfx_param_traits.cc (right):

https://codereview.chromium.org/2229953003/diff/100001/ui/gfx/ipc/color/gfx_p...
ui/gfx/ipc/color/gfx_param_traits.cc:20: for (int i = 0; i < 12; i++) {
Nit: braces not needed on these inner one-liners (several places).

[hubbe, 2016-08-23 22:01:00]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 22:02:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 23:21:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 23:21:50]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[hubbe, 2016-08-23 23:50:01]

The CQ bit was checked by hubbe@chromium.org

[hubbe, 2016-08-23 23:50:01]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2229953003/#ps120001
(title: "nits addressed")

[commit-bot: I haz the power, 2016-08-23 23:50:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 00:53:59]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-24 00:55:57]

Description was changed from

==========
Support for custom primaries

When converting an ICC profile to a ColorSpace, the primaries are extracted.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Support for custom primaries

When converting an ICC profile to a ColorSpace, the primaries are extracted.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/24f935a3d8cdfcdfbabd23928a42304b1ffc52ba
Cr-Commit-Position: refs/heads/master@{#413914}
==========

[commit-bot: I haz the power, 2016-08-24 00:55:58]

Patchset 7 (id:??) landed as
https://crrev.com/24f935a3d8cdfcdfbabd23928a42304b1ffc52ba
Cr-Commit-Position: refs/heads/master@{#413914}

[sakal-chromium, 2016-08-24 11:11:44]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2271683004/ by sakal@chromium.org.

The reason for reverting is: Causes a crash in
WebRtcApprtcBrowserTest.MANUAL_FirefoxApprtcInteropTest.

[72802:72802:0824/130437:FATAL:list_container_helper.cc(460)] Check failed:
size_of_actual_element_in_bytes <= data_->element_size() (240 vs. 224)

Command line used to run the test:
./out/Debug/browser_tests --fast-local-dev
--gtest_filter="*FirefoxApprtcInteropTest*" --run-manual
--ui-test-action-max-timeout=150000.

[hubbe, 2016-08-25 17:30:11]

Description was changed from

==========
Support for custom primaries

When converting an ICC profile to a ColorSpace, the primaries are extracted.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/24f935a3d8cdfcdfbabd23928a42304b1ffc52ba
Cr-Commit-Position: refs/heads/master@{#413914}
==========

to

==========
Support for custom primaries

When converting an ICC profile to a ColorSpace, the primaries are extracted.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/24f935a3d8cdfcdfbabd23928a42304b1ffc52ba
Cr-Commit-Position: refs/heads/master@{#413914}
==========

[hubbe, 2016-08-25 19:01:17]

Patchset #8 (id:140001) has been deleted

[hubbe, 2016-08-25 19:03:22]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 19:04:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 20:12:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 20:12:27]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[hubbe, 2016-08-25 21:44:02]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:44:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2016-08-25 22:52:40]

The CQ bit was unchecked by hubbe@chromium.org

[hubbe, 2016-08-25 22:52:45]

The CQ bit was checked by hubbe@chromium.org

[hubbe, 2016-08-25 22:52:45]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2229953003/#ps180001
(title: "test updated")

[commit-bot: I haz the power, 2016-08-25 22:53:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 23:36:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 23:36:14]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hubbe, 2016-08-25 23:57:35]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2016-08-25 23:58:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 01:03:34]

Description was changed from

==========
Support for custom primaries

When converting an ICC profile to a ColorSpace, the primaries are extracted.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/24f935a3d8cdfcdfbabd23928a42304b1ffc52ba
Cr-Commit-Position: refs/heads/master@{#413914}
==========

to

==========
Support for custom primaries

When converting an ICC profile to a ColorSpace, the primaries are extracted.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/24f935a3d8cdfcdfbabd23928a42304b1ffc52ba
Cr-Commit-Position: refs/heads/master@{#413914}
==========

[commit-bot: I haz the power, 2016-08-26 01:03:35]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2016-08-26 01:05:14]

Description was changed from

==========
Support for custom primaries

When converting an ICC profile to a ColorSpace, the primaries are extracted.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/24f935a3d8cdfcdfbabd23928a42304b1ffc52ba
Cr-Commit-Position: refs/heads/master@{#413914}
==========

to

==========
Support for custom primaries

When converting an ICC profile to a ColorSpace, the primaries are extracted.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/24f935a3d8cdfcdfbabd23928a42304b1ffc52ba
Committed: https://crrev.com/1ae106dbab4bddd85132d5b75c670794311f4c57
Cr-Original-Commit-Position: refs/heads/master@{#413914}
Cr-Commit-Position: refs/heads/master@{#414607}
==========

[commit-bot: I haz the power, 2016-08-26 01:05:16]

Patchset 9 (id:??) landed as
https://crrev.com/1ae106dbab4bddd85132d5b75c670794311f4c57
Cr-Commit-Position: refs/heads/master@{#414607}