Remove dependency on test_runner from some components unittests.

Remove dependency on test_runner from some components unittests.

Remove test_runner::EnsureBlinkInitialized() calls in some components
unittests. Instead add blink initialization to components/test/
run_all_unittests.cc via content::UnitTestTestSuite (on non-IOS
platforms). This also allows to remove the dependency on
components/test_runner from a few individual components. Also
removes dependency on //ui/events/platform/x11 from two
components/bookmarks/browser/ unit tests.

BUG=634326
Committed: https://crrev.com/1774dc23b16b6e082f958fcc99545f18020241e1
Cr-Commit-Position: refs/heads/master@{#411202}

[timvolodine, 2016-08-09 20:59:00]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 21:00:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-08-09 21:28:33]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 21:28:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 22:14:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 22:14:57]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jam, 2016-08-09 23:58:42]

jam@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2016-08-09 23:58:43]

to fix the tests, you can remove
https://cs.chromium.org/chromium/src/components/bookmarks/browser/bookmark_ut...
and
https://cs.chromium.org/chromium/src/components/bookmarks/browser/bookmark_no...

lgtm with that

[timvolodine, 2016-08-10 14:08:26]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 14:08:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-08-10 14:58:42]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 14:59:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 15:17:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 15:17:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[timvolodine, 2016-08-10 15:47:40]

Description was changed from

==========
Remove dependency on test_runner from some components unittests.

Remove test_runner::EnsureBlinkInitialized() calls in some components
unittests. Instead add blink initialization to components/test/
run_all_unittests.cc via content::UnitTestTestSuite (on non-IOS
platforms). This also allows to remove the dependecy on
components/test_runner from a few individual components.

BUG=634326
==========

to

==========
Remove dependency on test_runner from some components unittests.

Remove test_runner::EnsureBlinkInitialized() calls in some components
unittests. Instead add blink initialization to components/test/
run_all_unittests.cc via content::UnitTestTestSuite (on non-IOS
platforms). This also allows to remove the dependency on
components/test_runner from a few individual components. Also
removes dependency on //ui/events/platform/x11 from two
components/bookmarks/browser/ unit tests.

BUG=634326
==========

[timvolodine, 2016-08-10 15:48:58]

On 2016/08/09 23:58:43, jam wrote:
> to fix the tests, you can remove
>
https://cs.chromium.org/chromium/src/components/bookmarks/browser/bookmark_ut...
> and
>
https://cs.chromium.org/chromium/src/components/bookmarks/browser/bookmark_no...
> 
> lgtm with that

thanks jam@! that seemed to help -- removed the event_source_ and dependencies
completely.

[timvolodine, 2016-08-10 15:50:41]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2016-08-10 15:50:41]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2229943002/#ps60001
(title: "update BUILD.gn dependencies")

[commit-bot: I haz the power, 2016-08-10 15:51:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 15:55:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 15:55:09]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[timvolodine, 2016-08-10 17:12:23]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2016-08-10 17:13:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 18:46:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 18:46:11]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[timvolodine, 2016-08-10 18:47:07]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2016-08-10 18:47:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 20:36:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 20:36:15]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[timvolodine, 2016-08-10 21:02:52]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2016-08-10 21:03:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-08-10 21:50:19]

android is failing because the v8 data needs to be added to data_deps. here's
the fix:
https://codereview.chromium.org/2233973003/diff/50001/components/BUILD.gn

[timvolodine, 2016-08-10 22:28:41]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[timvolodine, 2016-08-10 22:29:04]

The CQ bit was unchecked by timvolodine@chromium.org

[timvolodine, 2016-08-10 22:29:21]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2016-08-10 22:29:21]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2229943002/#ps80001
(title: "apply jam's fix for android from crrev.com/2233973003")

[commit-bot: I haz the power, 2016-08-10 22:30:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-08-10 22:37:35]

On 2016/08/10 21:50:19, jam wrote:
> android is failing because the v8 data needs to be added to data_deps. here's
> the fix:
> https://codereview.chromium.org/2233973003/diff/50001/components/BUILD.gn

ah, was assuming it was a broken bot, there was some redness earlier during the
day.. it's a bit weird since it did not seem to be required previously. would
not have found it straight away (if at all) without your help -- thanks!!

[commit-bot: I haz the power, 2016-08-11 00:29:00]

Description was changed from

==========
Remove dependency on test_runner from some components unittests.

Remove test_runner::EnsureBlinkInitialized() calls in some components
unittests. Instead add blink initialization to components/test/
run_all_unittests.cc via content::UnitTestTestSuite (on non-IOS
platforms). This also allows to remove the dependency on
components/test_runner from a few individual components. Also
removes dependency on //ui/events/platform/x11 from two
components/bookmarks/browser/ unit tests.

BUG=634326
==========

to

==========
Remove dependency on test_runner from some components unittests.

Remove test_runner::EnsureBlinkInitialized() calls in some components
unittests. Instead add blink initialization to components/test/
run_all_unittests.cc via content::UnitTestTestSuite (on non-IOS
platforms). This also allows to remove the dependency on
components/test_runner from a few individual components. Also
removes dependency on //ui/events/platform/x11 from two
components/bookmarks/browser/ unit tests.

BUG=634326
==========

[commit-bot: I haz the power, 2016-08-11 00:29:01]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-11 00:31:36]

Description was changed from

==========
Remove dependency on test_runner from some components unittests.

Remove test_runner::EnsureBlinkInitialized() calls in some components
unittests. Instead add blink initialization to components/test/
run_all_unittests.cc via content::UnitTestTestSuite (on non-IOS
platforms). This also allows to remove the dependency on
components/test_runner from a few individual components. Also
removes dependency on //ui/events/platform/x11 from two
components/bookmarks/browser/ unit tests.

BUG=634326
==========

to

==========
Remove dependency on test_runner from some components unittests.

Remove test_runner::EnsureBlinkInitialized() calls in some components
unittests. Instead add blink initialization to components/test/
run_all_unittests.cc via content::UnitTestTestSuite (on non-IOS
platforms). This also allows to remove the dependency on
components/test_runner from a few individual components. Also
removes dependency on //ui/events/platform/x11 from two
components/bookmarks/browser/ unit tests.

BUG=634326

Committed: https://crrev.com/1774dc23b16b6e082f958fcc99545f18020241e1
Cr-Commit-Position: refs/heads/master@{#411202}
==========

[commit-bot: I haz the power, 2016-08-11 00:31:38]

Patchset 5 (id:??) landed as
https://crrev.com/1774dc23b16b6e082f958fcc99545f18020241e1
Cr-Commit-Position: refs/heads/master@{#411202}