components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc - Issue 2229943002: Remove dependency on test_runner from some components unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

Issue 2229943002: Remove dependency on test_runner from some components unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: apply jam's fix for android from crrev.com/2233973003 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/renderer/document_subresource_filter_unittest.cc ('k') | components/test/run_all_unittests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

index c6f34e2b9099c419871aa257d1623d6fbdcc5a7f..9ac265616236d11eeb770dc19b22b570c59063de 100644

--- a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

+++ b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

@@ -14,7 +14,6 @@

#include "components/subresource_filter/content/common/subresource_filter_messages.h"

#include "components/subresource_filter/content/renderer/ruleset_dealer.h"

#include "components/subresource_filter/core/common/test_ruleset_creator.h"

-#include "components/test_runner/test_common.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "third_party/WebKit/public/platform/WebDocumentSubresourceFilter.h"

@@ -70,7 +69,7 @@ const char kTestBothURLsPathSuffix[] = "a";

class SubresourceFilterAgentTest : public ::testing::Test {

public:

- SubresourceFilterAgentTest() { test_runner::EnsureBlinkInitialized(); }

+ SubresourceFilterAgentTest() {}

protected:

void SetUp() override {