Issue 222943002: Pull Gpu shader out of SkTwoPointConicalGradient into own file

Issue 222943002: Pull Gpu shader out of SkTwoPointConicalGradient into own file (Closed)

Created:
6 years, 8 months ago by egdaniel

Modified:
6 years, 8 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Pull Gpu shader out of SkTwoPointConicalGradient into own file BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14044

Patch Set 2 : Remove includes #

Total comments: 4

Patch Set 3 : Gpu Support Check #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+386 lines, -351 lines)			Patch
M	gyp/effects.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View	1 2	3 chunks	+3 lines, -349 lines	0 comments	Download
A	src/effects/gradients/SkTwoPointConicalGradient_gpu.h	View	1 2	1 chunk	+73 lines, -0 lines	0 comments	Download
A	src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp	View	1 2	1 chunk	+306 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm w/ a couple naming suggestions. https://codereview.chromium.org/222943002/diff/20001/gyp/effects.gypi File gyp/effects.gypi (right): https://codereview.chromium.org/222943002/diff/20001/gyp/effects.gypi#newcode80 gyp/effects.gypi:80: '<(skia_src_path)/effects/gradients/SkTwoPointConicalGradient_Gpu.cpp', for consistency ...

6 years, 8 months ago (2014-04-02 21:12:03 UTC) #2

egdaniel

https://codereview.chromium.org/222943002/diff/20001/gyp/effects.gypi File gyp/effects.gypi (right): https://codereview.chromium.org/222943002/diff/20001/gyp/effects.gypi#newcode80 gyp/effects.gypi:80: '<(skia_src_path)/effects/gradients/SkTwoPointConicalGradient_Gpu.cpp', done On 2014/04/02 21:12:04, bsalomon wrote: > for ...

6 years, 8 months ago (2014-04-03 14:36:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/222943002/60001

6 years, 8 months ago (2014-04-03 14:37:24 UTC) #5

Message was sent while issue was closed.

Change committed as 14044

Expand Messages | Collapse Messages