Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2228983002: [turbofan] Simplify BinaryOperationHints and CompareOperationHints. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Simplify BinaryOperationHints and CompareOperationHints. Remove the useless information from the BinaryOperationHints and CompareOperationHints, and cache the JS operators appropriately. R=epertoso@chromium.org Committed: https://crrev.com/a12aa891510d6c66a4c3ca4c986ab5112451ef6d Cr-Commit-Position: refs/heads/master@{#38506}

Patch Set 1 #

Patch Set 2 : Same for CompareOperationHints. #

Patch Set 3 : Fix compile #

Patch Set 4 : Fix compile for realz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -685 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 13 chunks +44 lines, -45 lines 0 comments Download
M src/compiler/bytecode-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 7 chunks +55 lines, -55 lines 0 comments Download
M src/compiler/js-operator.h View 1 2 chunks +22 lines, -21 lines 0 comments Download
M src/compiler/js-operator.cc View 1 4 chunks +119 lines, -197 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 chunks +12 lines, -20 lines 0 comments Download
M src/compiler/type-hint-analyzer.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/type-hint-analyzer.cc View 1 2 chunks +38 lines, -44 lines 0 comments Download
M src/compiler/type-hints.h View 1 2 3 1 chunk +23 lines, -89 lines 0 comments Download
M src/compiler/type-hints.cc View 1 2 3 chunks +13 lines, -62 lines 0 comments Download
M src/ic/ic-state.h View 1 2 chunks +18 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 7 chunks +16 lines, -16 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 26 chunks +73 lines, -113 lines 0 comments Download
M test/unittests/compiler/typer-unittest.cc View 1 4 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-09 14:12:05 UTC) #1
epertoso
lgtm
4 years, 4 months ago (2016-08-09 14:30:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228983002/20001
4 years, 4 months ago (2016-08-09 17:27:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/20949) v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-09 17:30:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228983002/40001
4 years, 4 months ago (2016-08-09 17:35:20 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/12185)
4 years, 4 months ago (2016-08-09 17:39:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228983002/60001
4 years, 4 months ago (2016-08-09 17:46:11 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-09 18:12:03 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 18:12:20 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a12aa891510d6c66a4c3ca4c986ab5112451ef6d
Cr-Commit-Position: refs/heads/master@{#38506}

Powered by Google App Engine
This is Rietveld 408576698