Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 2228983002: [turbofan] Simplify BinaryOperationHints and CompareOperationHints. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix compile for realz Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-operator.cc ('k') | src/compiler/type-hint-analyzer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-typed-lowering.cc
diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc
index 878c32d1bed0c152dff592ff0578088b8715bcb9..776d57ce10cfa0db12b1703f749e6e094ac386e2 100644
--- a/src/compiler/js-typed-lowering.cc
+++ b/src/compiler/js-typed-lowering.cc
@@ -33,20 +33,18 @@ class JSBinopReduction final {
DCHECK_NE(0, node_->op()->ControlOutputCount());
DCHECK_EQ(1, node_->op()->EffectOutputCount());
DCHECK_EQ(1, OperatorProperties::GetFrameStateInputCount(node_->op()));
- BinaryOperationHints hints = BinaryOperationHintsOf(node_->op());
- switch (hints.combined()) {
- case BinaryOperationHints::kSignedSmall:
+ switch (BinaryOperationHintOf(node_->op())) {
+ case BinaryOperationHint::kSignedSmall:
*hint = NumberOperationHint::kSignedSmall;
return true;
- case BinaryOperationHints::kSigned32:
+ case BinaryOperationHint::kSigned32:
*hint = NumberOperationHint::kSigned32;
return true;
- case BinaryOperationHints::kNumberOrOddball:
+ case BinaryOperationHint::kNumberOrOddball:
*hint = NumberOperationHint::kNumberOrOddball;
return true;
- case BinaryOperationHints::kAny:
- case BinaryOperationHints::kNone:
- case BinaryOperationHints::kString:
+ case BinaryOperationHint::kAny:
+ case BinaryOperationHint::kNone:
break;
}
}
@@ -56,24 +54,18 @@ class JSBinopReduction final {
bool GetCompareNumberOperationHint(NumberOperationHint* hint) {
if (lowering_->flags() & JSTypedLowering::kDeoptimizationEnabled) {
DCHECK_EQ(1, node_->op()->EffectOutputCount());
- CompareOperationHints hints = CompareOperationHintsOf(node_->op());
- switch (hints.combined()) {
- case CompareOperationHints::kSignedSmall:
+ switch (CompareOperationHintOf(node_->op())) {
+ case CompareOperationHint::kSignedSmall:
*hint = NumberOperationHint::kSignedSmall;
return true;
- case CompareOperationHints::kNumber:
+ case CompareOperationHint::kNumber:
*hint = NumberOperationHint::kNumber;
return true;
- case CompareOperationHints::kNumberOrOddball:
+ case CompareOperationHint::kNumberOrOddball:
*hint = NumberOperationHint::kNumberOrOddball;
return true;
- case CompareOperationHints::kAny:
- case CompareOperationHints::kNone:
- case CompareOperationHints::kString:
- case CompareOperationHints::kBoolean:
- case CompareOperationHints::kUniqueName:
- case CompareOperationHints::kInternalizedString:
- case CompareOperationHints::kReceiver:
+ case CompareOperationHint::kAny:
+ case CompareOperationHint::kNone:
break;
}
}
« no previous file with comments | « src/compiler/js-operator.cc ('k') | src/compiler/type-hint-analyzer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698