Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2228973002: PPC/s390: [turbofan] Remove the FloatXXSubPreserveNan operators. (Closed)

Created:
4 years, 4 months ago by JaideepBajwa
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [turbofan] Remove the FloatXXSubPreserveNan operators. Port f8938e50964e7b83818a0fff7fc0f2b065f8bf49 Original commit message: This CL changes the semantics of FloatXXSub to match the semantics of the semantics of FloatXXSubPreserveNan. Therefore there is no need anymore for the FloatXXSubPreserveNan operators. The optimizations in VisitFloatXXSub which are removed in this CL have already been moved to machine-operator-reducer.cc in https://codereview.chromium.org/2226663002 R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/2b15dd52ad7bdc041e2b7bd4a3b3f230580778e3 Cr-Commit-Position: refs/heads/master@{#38524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -72 lines) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
john.yan
lgtm
4 years, 4 months ago (2016-08-09 13:48:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228973002/1
4 years, 4 months ago (2016-08-09 13:50:07 UTC) #3
commit-bot: I haz the power
Failed to commit the patch.
4 years, 4 months ago (2016-08-09 14:10:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228973002/1
4 years, 4 months ago (2016-08-09 14:47:28 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
4 years, 4 months ago (2016-08-09 14:49:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228973002/1
4 years, 4 months ago (2016-08-10 08:58:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 09:03:51 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 09:04:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b15dd52ad7bdc041e2b7bd4a3b3f230580778e3
Cr-Commit-Position: refs/heads/master@{#38524}

Powered by Google App Engine
This is Rietveld 408576698