MacViews: Fix behavior of move and select commands when selection direction changes.

ui/gfx/render_text.h

Index: ui/gfx/render_text.h
diff --git a/ui/gfx/render_text.h b/ui/gfx/render_text.h
index 9265d9d0166b804aaeaeb5c9e19defb634d560c3..da18daa830291c1e37ab275361c693f466bbf1df 100644
--- a/ui/gfx/render_text.h
+++ b/ui/gfx/render_text.h
@@ -329,9 +329,13 @@ class GFX_EXPORT RenderText {
   // Moves the cursor left or right. Cursor movement is visual, meaning that
   // left and right are relative to screen, not the directionality of the text.
   // If |select| is false, the selection start is moved to the same position.
-  void MoveCursor(BreakType break_type,
-                  VisualCursorDirection direction,
-                  bool select);
+  // |select_behavior| specifies the selection behavior in case the selection
+  // direction is reversed.
+  void MoveCursor(
+      BreakType break_type,
+      VisualCursorDirection direction,
+      bool select,
+      SelectionReversedBehavior select_behavior = SELECTION_DEFAULT);

[tapted, 2016/08/11 03:44:07]

This isn't a good use of default arguments - if |select| is true we want the
caller to think about how it should behave - see later comment.

[karandeepb, 2016/08/16 10:24:51]

Acknowledged, removed the use of default args.

 
   // Set the selection_model_ to the value of |selection|.
   // The selection range is clamped to text().length() if out of range.