check_return_value.py should drop stderr of the command it runs.

check_return_value.py should drop stderr of the command it runs.

Gyp will treat the command as failed if there is any stderr output.
However, we're interested in the actual return value anyways.

BUG=359096
R=mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261307

[Mark Mentovai, 2014-04-02 20:12:29]

LGTM

https://codereview.chromium.org/222883002/diff/1/build/check_return_value.py
File build/check_return_value.py (right):

https://codereview.chromium.org/222883002/diff/1/build/check_return_value.py#...
build/check_return_value.py:14: if not subprocess.call(sys.argv[1:],
stderr=devnull):
I think you should also suppress stdout, since you want to replace it with your
own stdout.

[jochen (gone - plz use gerrit), 2014-04-02 20:13:23]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2014-04-02 20:14:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/222883002/2

[jochen (gone - plz use gerrit), 2014-04-03 06:57:08]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2014-04-03 06:57:10]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2014-04-03 07:36:38]

Committed patchset #2 manually as r261307 (presubmit successful).