Chromium Code Reviews Chromium Code Reviews
Issue 222883002:
check_return_value.py should drop stderr of the command it runs. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 #!/usr/bin/env python | 1 #!/usr/bin/env python |
| 2 # Copyright 2014 The Chromium Authors. All rights reserved. | 2 # Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 # Use of this source code is governed by a BSD-style license that can be | 3 # Use of this source code is governed by a BSD-style license that can be |
| 4 # found in the LICENSE file. | 4 # found in the LICENSE file. |
| 5 | 5 |
| 6 """This program wraps an arbitrary command and prints "1" if the command ran | 6 """This program wraps an arbitrary command and prints "1" if the command ran |
| 7 successfully.""" | 7 successfully.""" |
| 8 | 8 |
| 9 import os | |
| 9 import subprocess | 10 import subprocess |
| 10 import sys | 11 import sys |
| 11 | 12 |
| 12 if not subprocess.call(sys.argv[1:]): | 13 devnull = open(os.devnull, 'wb') |
| 14 if not subprocess.call(sys.argv[1:], stderr=devnull): | |
|
Mark Mentovai
2014/04/02 20:12:30
I think you should also suppress stdout, since you
| |
| 13 print 1 | 15 print 1 |
| 14 else: | 16 else: |
| 15 print 0 | 17 print 0 |
| OLD | NEW |
