Remove AnimationEffectTimingProperties playbackRate

Remove AnimationEffectTimingProperties playbackRate

The playbackRate property in AnimationEffectTimingProperties.idl is no longer
part of the spec. This patch removes it and places that expect
ComputedTimingProperties and KeyframeEffectOptions (which inherit from
AnimationEffectTimingProperties) to have playbackRate fields.

The playbackRate field of the Timing object, which in TimingInput.cpp is
initialized from the AnimationEffectTimingProperties playbackRate field, is left
intact because it is more widely used through the code. A dummy 1.0 value is
used instead in this one location.

BUG=624639
Committed: https://crrev.com/b084e73aae95c6324c39ae87e74a5412b85df0d2
Cr-Commit-Position: refs/heads/master@{#411237}

[samli, 2016-08-09 03:29:32]

samli@chromium.org changed reviewers:
+ samli@chromium.org

[samli, 2016-08-09 03:29:33]

Can you also remove this from AnimationModel.js too please? I've checked,
shouldn't be any references to it.

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front...

[suzyh_UTC10 (ex-contributor), 2016-08-09 03:42:43]

On 2016/08/09 at 03:29:33, samli wrote:
> Can you also remove this from AnimationModel.js too please? I've checked,
shouldn't be any references to it.
> 
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front...

Done.

[suzyh_UTC10 (ex-contributor), 2016-08-09 03:43:02]

suzyh@chromium.org changed reviewers:
+ alancutter@chromium.org, pfeldman@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-08-09 03:43:14]

+alancutter
+pfeldman for core/inspector

[samli, 2016-08-09 03:45:34]

lgtm devtools changes

[alancutter (OOO until 2018), 2016-08-09 03:45:49]

LGTM.

https://codereview.chromium.org/2228773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/TimingInput.cpp (right):

https://codereview.chromium.org/2228773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/TimingInput.cpp:133:
setPlaybackRate(timingOutput, 1.0);
TODO remove Timing::playbackRate.

[suzyh_UTC10 (ex-contributor), 2016-08-09 03:56:33]

On 2016/08/09 at 03:45:49, alancutter wrote:
> LGTM.
> 
>
https://codereview.chromium.org/2228773002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/animation/TimingInput.cpp (right):
> 
>
https://codereview.chromium.org/2228773002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/animation/TimingInput.cpp:133:
setPlaybackRate(timingOutput, 1.0);
> TODO remove Timing::playbackRate.

Done.

[suzyh_UTC10 (ex-contributor), 2016-08-09 03:57:42]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 03:58:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 07:38:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 07:38:49]

Dry run: This issue passed the CQ dry run.

[suzyh_UTC10 (ex-contributor), 2016-08-10 00:25:30]

Ping for pfeldman in case this review got missed. Feel free to bump to another
core/inspector OWNER if desired. Thanks!

[pfeldman, 2016-08-11 00:49:50]

inspector lgtm, thanks.

[suzyh_UTC10 (ex-contributor), 2016-08-11 00:50:16]

The CQ bit was checked by suzyh@chromium.org

[suzyh_UTC10 (ex-contributor), 2016-08-11 00:50:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org, samli@chromium.org
Link to the patchset: https://codereview.chromium.org/2228773002/#ps40001
(title: "Add TODO")

[commit-bot: I haz the power, 2016-08-11 00:51:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 02:57:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-11 02:58:24]

Description was changed from

==========
Remove AnimationEffectTimingProperties playbackRate

The playbackRate property in AnimationEffectTimingProperties.idl is no longer
part of the spec. This patch removes it and places that expect
ComputedTimingProperties and KeyframeEffectOptions (which inherit from
AnimationEffectTimingProperties) to have playbackRate fields.

The playbackRate field of the Timing object, which in TimingInput.cpp is
initialized from the AnimationEffectTimingProperties playbackRate field, is left
intact because it is more widely used through the code. A dummy 1.0 value is
used instead in this one location.

BUG=624639
==========

to

==========
Remove AnimationEffectTimingProperties playbackRate

The playbackRate property in AnimationEffectTimingProperties.idl is no longer
part of the spec. This patch removes it and places that expect
ComputedTimingProperties and KeyframeEffectOptions (which inherit from
AnimationEffectTimingProperties) to have playbackRate fields.

The playbackRate field of the Timing object, which in TimingInput.cpp is
initialized from the AnimationEffectTimingProperties playbackRate field, is left
intact because it is more widely used through the code. A dummy 1.0 value is
used instead in this one location.

BUG=624639

Committed: https://crrev.com/b084e73aae95c6324c39ae87e74a5412b85df0d2
Cr-Commit-Position: refs/heads/master@{#411237}
==========

[commit-bot: I haz the power, 2016-08-11 02:58:26]

Patchset 3 (id:??) landed as
https://crrev.com/b084e73aae95c6324c39ae87e74a5412b85df0d2
Cr-Commit-Position: refs/heads/master@{#411237}