third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp - Issue 2228773002: Remove AnimationEffectTimingProperties playbackRate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

Issue 2228773002: Remove AnimationEffectTimingProperties playbackRate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@idl-updates

Patch Set: Add TODO Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationEffectTimingProperties.idl ('k') | third_party/WebKit/Source/core/animation/Timing.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

index 8f7ae0cd3c5ae3cf802404a2085b3ff98a41691d..0e84e153d6fb094abbb8cb38d2b822d6f1d5a07e 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp

@@ -127,7 +127,6 @@ TEST_F(AnimationKeyframeEffectV8Test, SpecifiedGetters)

setV8ObjectPropertyAsString(scope.isolate(), timingInput, "fill", "backwards");

setV8ObjectPropertyAsNumber(scope.isolate(), timingInput, "iterationStart", 2);

setV8ObjectPropertyAsNumber(scope.isolate(), timingInput, "iterations", 10);

- setV8ObjectPropertyAsNumber(scope.isolate(), timingInput, "playbackRate", 2);

setV8ObjectPropertyAsString(scope.isolate(), timingInput, "direction", "reverse");

setV8ObjectPropertyAsString(scope.isolate(), timingInput, "easing", "step-start");

KeyframeEffectOptions timingInputDictionary;

@@ -141,7 +140,6 @@ TEST_F(AnimationKeyframeEffectV8Test, SpecifiedGetters)

EXPECT_EQ("backwards", specified->fill());

EXPECT_EQ(2, specified->iterationStart());

EXPECT_EQ(10, specified->iterations());

- EXPECT_EQ(2, specified->playbackRate());

EXPECT_EQ("reverse", specified->direction());

EXPECT_EQ("step-start", specified->easing());

}