Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2228633005: Cancel composition on RenderWidgetHostCocoaView after a child frame's RWHV receives the correspondi… (Closed)

Created:
4 years, 4 months ago by EhsanK
Modified:
4 years, 4 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cancel composition on RenderWidgetHostCocoaView after a child frame's RWHV receives the corresponding IPC. This CL will add the required plumbing for Mac to cancel an ongoing composition on the browser side when the renderer has canceled its ongoing composition. BUG=578168, 602723 Committed: https://crrev.com/7006d2f9c3804eb9a6aedbb328223b22df51eacc Cr-Commit-Position: refs/heads/master@{#411151}

Patch Set 1 #

Patch Set 2 : Added a unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 1 chunk +27 lines, -0 lines 0 comments Download
M content/test/test_render_view_host.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (18 generated)
EhsanK
PTAL. This patch reminded me that we need a similar test for Aura. I will ...
4 years, 4 months ago (2016-08-09 23:48:22 UTC) #9
kenrb
lgtm
4 years, 4 months ago (2016-08-10 19:40:48 UTC) #12
Charlie Reis
I'm not a Cocoa reviewer; maybe Avi can do a quick sanity check on the ...
4 years, 4 months ago (2016-08-10 19:43:53 UTC) #14
Avi (use Gerrit)
LGTM
4 years, 4 months ago (2016-08-10 19:58:11 UTC) #15
EhsanK
Thank you for the reviews!
4 years, 4 months ago (2016-08-10 19:59:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228633005/20001
4 years, 4 months ago (2016-08-10 21:30:59 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 21:38:49 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 21:40:47 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7006d2f9c3804eb9a6aedbb328223b22df51eacc
Cr-Commit-Position: refs/heads/master@{#411151}

Powered by Google App Engine
This is Rietveld 408576698