content/browser/renderer_host/render_widget_host_view_base.cc - Issue 2228633005: Cancel composition on RenderWidgetHostCocoaView after a child frame's RWHV receives the correspondi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 2228633005: Cancel composition on RenderWidgetHostCocoaView after a child frame's RWHV receives the correspondi… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added a unit test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_widget_host_view_base.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc

index 7db1dcd6878a46b8e3bcd0afb5001bb43bab45e6..3a295ca6aa47379ed112895855bc6b1368c0d8de 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.cc

+++ b/content/browser/renderer_host/render_widget_host_view_base.cc

@@ -445,7 +445,7 @@ void RenderWidgetHostViewBase::TextInputStateChanged(

void RenderWidgetHostViewBase::ImeCancelComposition() {

// TODO(ekaramad): Use TextInputManager code paths for IME on other platforms.

-#if defined(USE_AURA)

+#if !defined(OS_ANDROID)

if (GetTextInputManager())

GetTextInputManager()->ImeCancelComposition(this);

#endif

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_mac.h » ('j') | no next file with comments »