Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: build/config/compiler/compiler.gni

Issue 2228633002: clang/win: Stop disabling symbols by default in debug builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: foo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/chromecast_build.gni") 7 import("//build/config/chromecast_build.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 import("//build/toolchain/toolchain.gni") 9 import("//build/toolchain/toolchain.gni")
10 10
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 current_cpu == "arm"))) 75 current_cpu == "arm")))
76 } 76 }
77 77
78 # If it wasn't manually set, set to an appropriate default. 78 # If it wasn't manually set, set to an appropriate default.
79 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level") 79 assert(symbol_level >= -1 && symbol_level <= 2, "Invalid symbol_level")
80 if (symbol_level == -1) { 80 if (symbol_level == -1) {
81 if (is_android && use_order_profiling) { 81 if (is_android && use_order_profiling) {
82 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which 82 # With instrumentation enabled, debug info puts libchrome.so over 4gb, which
83 # causes the linker to produce an invalid ELF. http://crbug.com/574476 83 # causes the linker to produce an invalid ELF. http://crbug.com/574476
84 symbol_level = 0 84 symbol_level = 0
85 } else if (is_win && is_clang && !using_sanitizer) {
86 # TODO(thakis): Remove this again once building with clang/win and
87 # debug info doesn't make link.exe run for hours.
88 symbol_level = 1
89 } else if (!is_linux || is_debug || is_official_build || is_chromecast) { 85 } else if (!is_linux || is_debug || is_official_build || is_chromecast) {
90 # Linux is slowed by having symbols as part of the target binary, whereas 86 # Linux is slowed by having symbols as part of the target binary, whereas
91 # Mac and Windows have them separate, so in Release Linux, default them off, 87 # Mac and Windows have them separate, so in Release Linux, default them off,
92 # but keep them on for Official builds and Chromecast builds. 88 # but keep them on for Official builds and Chromecast builds.
93 symbol_level = 2 89 symbol_level = 2
94 } else if (using_sanitizer) { 90 } else if (using_sanitizer) {
95 # Sanitizers require symbols for filename suppressions to work. 91 # Sanitizers require symbols for filename suppressions to work.
96 symbol_level = 1 92 symbol_level = 1
97 } else { 93 } else {
98 symbol_level = 0 94 symbol_level = 0
99 } 95 }
100 } 96 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698