Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2228593005: [LayoutNG] Move createConstraintSpaceFromLayoutObject to NGConstraintSpace (Closed)

Created:
4 years, 4 months ago by Gleb Lanbin
Modified:
4 years, 3 months ago
Reviewers:
cbiesinger, ikilpatrick, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Move createConstraintSpaceFromLayoutObject to NGConstraintSpace BUG=635619 R=cbiesinger@chromium.org, eae@chromium.org Committed: https://crrev.com/2546570633ceb9dde91fd59439ef96f3d1d8d064 Cr-Commit-Position: refs/heads/master@{#410802}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -32 lines) Patch
M third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp View 1 chunk +0 lines, -27 lines 1 comment Download
M third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h View 2 chunks +5 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.cpp View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Gleb Lanbin
4 years, 4 months ago (2016-08-09 19:18:34 UTC) #3
eae
LGTM https://codereview.chromium.org/2228593005/diff/20001/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h File third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h (right): https://codereview.chromium.org/2228593005/diff/20001/third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h#newcode56 third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h:56: static NGConstraintSpace fromLayoutObject(const LayoutBox&); Eventually we probably want ...
4 years, 4 months ago (2016-08-09 19:20:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228593005/20001
4 years, 4 months ago (2016-08-09 19:21:40 UTC) #9
cbiesinger
lgtm w/ nits https://codereview.chromium.org/2228593005/diff/20001/third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp File third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp (left): https://codereview.chromium.org/2228593005/diff/20001/third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp#oldcode7 third_party/WebKit/Source/core/layout/ng/NGBlockLayoutAlgorithm.cpp:7: #include "core/layout/LayoutBox.h" Can you keep these? ...
4 years, 4 months ago (2016-08-09 19:26:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-09 20:37:39 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 20:38:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2546570633ceb9dde91fd59439ef96f3d1d8d064
Cr-Commit-Position: refs/heads/master@{#410802}

Powered by Google App Engine
This is Rietveld 408576698