[LayoutNG] Move createConstraintSpaceFromLayoutObject to NGConstraintSpace

third_party/WebKit/Source/core/layout/ng/NGConstraintSpace.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NGConstraintSpace_h
 #define NGConstraintSpace_h
 
 #include "core/CoreExport.h"
 #include "platform/LayoutUnit.h"
 #include "wtf/DoublyLinkedList.h"
 
 namespace blink {
 
+class NGConstraintSpace;
 class NGDerivedConstraintSpace;
 class NGExclusion;
 class NGFragment;
 class NGLayoutOpportunityIterator;
+class LayoutBox;
 
 enum NGExclusionType {
     NGClearNone = 0,
     NGClearFloatLeft = 1,
     NGClearFloatRight = 2,
     NGClearFragment = 4
 };
 
 enum NGFragmentationType {
     FragmentNone,
@@ skipping 15 matching lines @@
     NGExclusion();
     ~NGExclusion() { }
 };
 
 class CORE_EXPORT NGConstraintSpace {
 public:
     NGConstraintSpace(LayoutUnit inlineContainerSize,
         LayoutUnit blockContainerSize);
     ~NGConstraintSpace() { }
 
+    // Constructs Layout NG constraint space from legacy layout object.

[cbiesinger, 2016/08/09 19:26:58]

Can you clarify in the comment that you have to pass the object that needs to be
laid out as the parameter? It may not be immediately clear that it is *not* the
container.

+    static NGConstraintSpace fromLayoutObject(const LayoutBox&);

[eae, 2016/08/09 19:20:22]

Eventually we probably want this (and similar methods) in a legacy_layout_bridge
file or similar but for now this makes sense.

+
     void addExclusion(const NGExclusion, unsigned options = 0);
     void setOverflowTriggersScrollbar(bool inlineTriggers,
         bool blockTriggers);
     void setFixedSize(bool inlineFixed, bool blockFixed);
     void setFragmentationType(NGFragmentationType);
 
     // Size of the container in each direction. Used for the following
     // three cases:
     // 1) Percentage resolution.
     // 2) Resolving absolute positions of children.
@@ skipping 94 matching lines @@
     LayoutUnit m_inlineOffset;
     LayoutUnit m_blockOffset;
     LayoutUnit m_inlineSize;
     LayoutUnit m_blockSize;
     NGConstraintSpace* m_original;
 };
 
 } // namespace blink
 
 #endif // NGConstraintSpace_h