Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2228543002: Clear needs_resize_ack when clearing DeviceMetricsOverride. (Closed)

Created:
4 years, 4 months ago by Eric Seckler
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear needs_resize_ack when clearing DeviceMetricsOverride. BUG=635560 Committed: https://crrev.com/722fb6bcbfc14db35e0b8a5546c9778827e7387c Cr-Commit-Position: refs/heads/master@{#410389}

Patch Set 1 #

Patch Set 2 : Add reference to bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/renderer/devtools/render_widget_screen_metrics_emulator.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Eric Seckler
Tiny fix for a sporadic debugging DCHECK failure :)
4 years, 4 months ago (2016-08-08 16:42:13 UTC) #3
dgozman
lgtm. Thank you for the fix!
4 years, 4 months ago (2016-08-08 16:53:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228543002/40001
4 years, 4 months ago (2016-08-08 16:56:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-08 17:51:52 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 17:53:59 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/722fb6bcbfc14db35e0b8a5546c9778827e7387c
Cr-Commit-Position: refs/heads/master@{#410389}

Powered by Google App Engine
This is Rietveld 408576698