Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: content/renderer/devtools/render_widget_screen_metrics_emulator.cc

Issue 2228543002: Clear needs_resize_ack when clearing DeviceMetricsOverride. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add reference to bug. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/devtools/render_widget_screen_metrics_emulator.cc
diff --git a/content/renderer/devtools/render_widget_screen_metrics_emulator.cc b/content/renderer/devtools/render_widget_screen_metrics_emulator.cc
index d5f4983f1395c563aae26b216aecdfffb69bd976..6c27f46570fe8912622ec1d850abaa1db971bd0b 100644
--- a/content/renderer/devtools/render_widget_screen_metrics_emulator.cc
+++ b/content/renderer/devtools/render_widget_screen_metrics_emulator.cc
@@ -25,6 +25,9 @@ RenderWidgetScreenMetricsEmulator::RenderWidgetScreenMetricsEmulator(
}
RenderWidgetScreenMetricsEmulator::~RenderWidgetScreenMetricsEmulator() {
+ // needs_resize_ack was handled during OnResize() and may cause a DCHECK to
+ // fail in RenderWidget if not cleared (crbug.com/635560).
+ original_resize_params_.needs_resize_ack = false;
delegate_->Resize(original_resize_params_);
delegate_->SetScreenMetricsEmulationParameters(false, emulation_params_);
delegate_->SetScreenRects(original_view_screen_rect_,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698