Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tools/perf/pylintrc

Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/pylintrc
diff --git a/tools/perf/pylintrc b/tools/perf/pylintrc
index 039dd565c1a75398f4a0b2a6122068944fb1bf2e..cf0e9b436b1d9d5ad9ac41049b848f1fbeaf82f9 100644
--- a/tools/perf/pylintrc
+++ b/tools/perf/pylintrc
@@ -2,7 +2,30 @@
# Disable the message, report, category or checker with the given id(s).
# TODO(perf-owners): Reduce this list to as small as possible.
-disable=I0010,I0011,abstract-class-little-used,abstract-class-not-used,anomalous-backslash-in-string,bad-builtin,bad-context-manager,bad-continuation,bad-indentation,bad-str-strip-call,bad-whitespace,broad-except,cell-var-from-loop,deprecated-lambda,deprecated-module,duplicate-code,eval-used,exec-used,fixme,function-redefined,global-statement,interface-not-implemented,invalid-name,locally-enabled,logging-not-lazy,missing-docstring,missing-final-newline,no-init,no-member,no-name-in-module,no-self-use,no-self-use,not-callable,reimported,star-args,super-on-old-class,too-few-public-methods,too-many-ancestors,too-many-arguments,too-many-branches,too-many-function-args,too-many-instance-attributes,too-many-lines,too-many-locals,too-many-public-methods,too-many-return-statements,too-many-statements,trailing-whitespace,useless-else-on-loop
+disable=
petrcermak 2016/08/11 08:51:13 I went through the list and it seems that while mo
petrcermak 2016/08/11 08:51:13 nit: Sort the items alphabetically? It's mostly th
nednguyen 2016/08/11 12:30:30 Done.
nednguyen 2016/08/11 12:30:30 Done.
nednguyen 2016/08/11 12:32:07 Note that locally-disabled only got triggered in t
+ design,
+ similarities,
+
petrcermak 2016/08/11 08:51:13 why the blank line?
nednguyen 2016/08/11 12:30:30 Done.
+ abstract-class-little-used,
+ abstract-class-not-used,
+ bad-builtin,
+ bad-continuation,
+ bad-whitespace,
+ bad-indentation,
+ broad-except,
+ eval-used,
+ fixme,
+ global-statement,
+ interface-not-implemented,
+ invalid-name,
+ locally-disabled,
+ locally-enabled,
+ logging-not-lazy,
+ missing-docstring,
+ no-member,
+ no-self-use,
+ protected-access,
+ star-args,
[REPORTS]

Powered by Google App Engine
This is Rietveld 408576698