Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: tools/perf/pylintrc

Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 [MESSAGES CONTROL] 1 [MESSAGES CONTROL]
2 2
3 # Disable the message, report, category or checker with the given id(s). 3 # Disable the message, report, category or checker with the given id(s).
4 # TODO(perf-owners): Reduce this list to as small as possible. 4 # TODO(perf-owners): Reduce this list to as small as possible.
5 disable=I0010,I0011,abstract-class-little-used,abstract-class-not-used,anomalous -backslash-in-string,bad-builtin,bad-context-manager,bad-continuation,bad-indent ation,bad-str-strip-call,bad-whitespace,broad-except,cell-var-from-loop,deprecat ed-lambda,deprecated-module,duplicate-code,eval-used,exec-used,fixme,function-re defined,global-statement,interface-not-implemented,invalid-name,locally-enabled, logging-not-lazy,missing-docstring,missing-final-newline,no-init,no-member,no-na me-in-module,no-self-use,no-self-use,not-callable,reimported,star-args,super-on- old-class,too-few-public-methods,too-many-ancestors,too-many-arguments,too-many- branches,too-many-function-args,too-many-instance-attributes,too-many-lines,too- many-locals,too-many-public-methods,too-many-return-statements,too-many-statemen ts,trailing-whitespace,useless-else-on-loop 5 disable=
petrcermak 2016/08/11 08:51:13 I went through the list and it seems that while mo
petrcermak 2016/08/11 08:51:13 nit: Sort the items alphabetically? It's mostly th
nednguyen 2016/08/11 12:30:30 Done.
nednguyen 2016/08/11 12:30:30 Done.
nednguyen 2016/08/11 12:32:07 Note that locally-disabled only got triggered in t
6 design,
7 similarities,
8
petrcermak 2016/08/11 08:51:13 why the blank line?
nednguyen 2016/08/11 12:30:30 Done.
9 abstract-class-little-used,
10 abstract-class-not-used,
11 bad-builtin,
12 bad-continuation,
13 bad-whitespace,
14 bad-indentation,
15 broad-except,
16 eval-used,
17 fixme,
18 global-statement,
19 interface-not-implemented,
20 invalid-name,
21 locally-disabled,
22 locally-enabled,
23 logging-not-lazy,
24 missing-docstring,
25 no-member,
26 no-self-use,
27 protected-access,
28 star-args,
6 29
7 30
8 [REPORTS] 31 [REPORTS]
9 32
10 # Don't write out full reports, just messages. 33 # Don't write out full reports, just messages.
11 reports=no 34 reports=no
12 35
13 36
14 [VARIABLES] 37 [VARIABLES]
15 38
16 # Google style 39 # Google style
17 dummy-variables-rgx=_$|unused_ 40 dummy-variables-rgx=_$|unused_
18 41
19 42
20 [FORMAT] 43 [FORMAT]
21 44
22 # We use two spaces for indents, instead of the usual four spaces or tab. 45 # We use two spaces for indents, instead of the usual four spaces or tab.
23 indent-string=' ' 46 indent-string=' '
24 47
25 # We suppress long line check for lines that contain only the URL (with or 48 # We suppress long line check for lines that contain only the URL (with or
26 # without quote). 49 # without quote).
27 ignore-long-lines=^\s*'?https?://\S+'?$ 50 ignore-long-lines=^\s*'?https?://\S+'?$
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698