tools/perf/page_sets/system_health/loading_stories.py - Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/system_health/loading_stories.py

Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/system_health/loading_stories.py

diff --git a/tools/perf/page_sets/system_health/loading_stories.py b/tools/perf/page_sets/system_health/loading_stories.py

index 961ccb46a1b521beec6f01adecedcf2906de9809..529fa8feccf2b4a2cc4e897b50e6df35cf6ff8c8 100644

--- a/tools/perf/page_sets/system_health/loading_stories.py

+++ b/tools/perf/page_sets/system_health/loading_stories.py

@@ -318,6 +318,7 @@ class LoadGmailMobileStory(_LoadGmailBaseStory):

'document.getElementById("apploadingdiv").style.height === "0px"')

petrcermak 2016/08/11 08:51:13 nit: Too many blank lines here (should be only 2)

nednguyen 2016/08/11 12:30:30 Done.

class LoadMapsStory(_LoadingStory):

NAME = 'load:tools:maps'

URL = 'https://www.google.com/maps/place/London,+UK/'

« no previous file with comments | « tools/perf/page_sets/memory_top_10_mobile.py ('k') | tools/perf/pylintrc » ('j') | tools/perf/pylintrc » ('J')