Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: tools/perf/page_sets/system_health/loading_stories.py

Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from page_sets.system_health import platforms 5 from page_sets.system_health import platforms
6 from page_sets.system_health import system_health_story 6 from page_sets.system_health import system_health_story
7 7
8 from page_sets.login_helpers import dropbox_login 8 from page_sets.login_helpers import dropbox_login
9 from page_sets.login_helpers import google_login 9 from page_sets.login_helpers import google_login
10 10
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 # Close the "Get Inbox by Gmail" interstitial. 311 # Close the "Get Inbox by Gmail" interstitial.
312 action_runner.WaitForJavaScriptCondition( 312 action_runner.WaitForJavaScriptCondition(
313 'document.querySelector("#isppromo a") !== null') 313 'document.querySelector("#isppromo a") !== null')
314 action_runner.ExecuteJavaScript( 314 action_runner.ExecuteJavaScript(
315 'document.querySelector("#isppromo a").click()') 315 'document.querySelector("#isppromo a").click()')
316 # Wait until the UI loads. 316 # Wait until the UI loads.
317 action_runner.WaitForJavaScriptCondition( 317 action_runner.WaitForJavaScriptCondition(
318 'document.getElementById("apploadingdiv").style.height === "0px"') 318 'document.getElementById("apploadingdiv").style.height === "0px"')
319 319
320 320
321
petrcermak 2016/08/11 08:51:13 nit: Too many blank lines here (should be only 2)
nednguyen 2016/08/11 12:30:30 Done.
321 class LoadMapsStory(_LoadingStory): 322 class LoadMapsStory(_LoadingStory):
322 NAME = 'load:tools:maps' 323 NAME = 'load:tools:maps'
323 URL = 'https://www.google.com/maps/place/London,+UK/' 324 URL = 'https://www.google.com/maps/place/London,+UK/'
324 325
325 326
326 class LoadStackOverflowStory(_LoadingStory): 327 class LoadStackOverflowStory(_LoadingStory):
327 NAME = 'load:tools:stackoverflow' 328 NAME = 'load:tools:stackoverflow'
328 URL = ( 329 URL = (
329 'https://stackoverflow.com/questions/36827659/compiling-an-application-for -use-in-highly-radioactive-environments') 330 'https://stackoverflow.com/questions/36827659/compiling-an-application-for -use-in-highly-radioactive-environments')
330 331
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 URL = 'http://www.miniclip.com/games/en/' 392 URL = 'http://www.miniclip.com/games/en/'
392 # Desktop only (requires Flash). 393 # Desktop only (requires Flash).
393 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY 394 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
394 395
395 396
396 class LoadAlphabettyStory(_LoadingStory): 397 class LoadAlphabettyStory(_LoadingStory):
397 NAME = 'load:games:alphabetty' 398 NAME = 'load:games:alphabetty'
398 URL = 'https://king.com/play/alphabetty' 399 URL = 'https://king.com/play/alphabetty'
399 # Desktop only (requires Flash). 400 # Desktop only (requires Flash).
400 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY 401 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698