Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2228403003: content: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
Reviewers:
no sievers
CC:
chromium-reviews, asanka, tzik, posciak+watch_chromium.org, nasko+codewatch_chromium.org, cbentzel+watch_chromium.org, rginda+watch_chromium.org, scheib+watch_chromium.org, ortuno+watch_chromium.org, kinuko+watch, miu+watch_chromium.org, jsbell+serviceworker_chromium.org, wjmaclean, iclelland+watch_chromium.org, jam, chasej+watch_chromium.org, eme-reviews_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, Peter Beverloo, Randy Smith (Not in Mondays), nhiroki, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, piman+watch_chromium.org, jsbell+idb_chromium.org, mlamouri+watch-manifest_chromium.org, jochen+watch_chromium.org, michaeln, mlamouri+watch-test-runner_chromium.org, serviceworker-reviews, dtapuska+chromiumwatch_chromium.org, kinuko+serviceworker, mmenke, cmumford, horo+watch_chromium.org, kinuko+fileapi, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/66bd679152fbafb7ecde93305f526004f4dac044 Cr-Commit-Position: refs/heads/master@{#411614}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -250 lines) Patch
M content/browser/android/synchronous_compositor_observer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/appcache/appcache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/appcache/appcache_backend_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_update_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_update_job_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/background_sync/background_sync_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/bluetooth/bluetooth_allowed_devices_map.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/bluetooth/web_bluetooth_service_impl.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/cache_storage/cache_storage.cc View 7 chunks +10 lines, -9 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M content/browser/devtools/protocol/tethering_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M content/browser/download/mhtml_generation_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_file_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M content/browser/file_descriptor_info_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_tree_node_blame_context_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/host_zoom_map_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_active_blob_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_scheduler.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/browser/manifest/manifest_manager_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/quota_policy_cookie_store_unittest.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M content/browser/plugin_private_storage_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/websocket_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_registry.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_database_unittest.cc View 11 chunks +25 lines, -25 lines 0 comments Download
M content/browser/service_worker/service_worker_job_coordinator.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_process_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 3 chunks +18 lines, -18 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/time_zone_monitor_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/resource_dispatcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M content/child/worker_thread_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/origin_util.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/public/test/download_test_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/mock_special_storage_policy.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/public/test/test_launcher.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M content/public/test/test_navigation_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/android/synchronous_compositor_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/gpu/frame_swap_message_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_track_recorder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/audio_track_recorder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/cdm/renderer_cdm_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_decoder.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (15 generated)
Sami
Sorry for the gigantic patch dude but it's a pretty straightforward transformation :)
4 years, 4 months ago (2016-08-10 17:01:40 UTC) #8
no sievers
lgtm
4 years, 4 months ago (2016-08-11 22:50:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228403003/20001
4 years, 4 months ago (2016-08-12 12:26:32 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 12:33:28 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 12:35:17 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66bd679152fbafb7ecde93305f526004f4dac044
Cr-Commit-Position: refs/heads/master@{#411614}

Powered by Google App Engine
This is Rietveld 408576698