Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 222833003: Remove irrelevant DCHECK that could hit (and it's ok) (Closed)

Created:
6 years, 8 months ago by kinuko
Modified:
6 years, 8 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

Remove irrelevant DCHECK that could hit (and it's ok) Looks like this DCHECK is just irrelevant. BUG=359438 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261366

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
kinuko
One-liner fix (with comments), can someone review this?
6 years, 8 months ago (2014-04-03 06:26:52 UTC) #1
dominicc (has gone to gerrit)
LGTM
6 years, 8 months ago (2014-04-03 07:11:26 UTC) #2
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 8 months ago (2014-04-03 07:17:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/222833003/20001
6 years, 8 months ago (2014-04-03 07:19:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:12:54 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:12:54 UTC) #6
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 8 months ago (2014-04-03 10:14:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/222833003/20001
6 years, 8 months ago (2014-04-03 10:18:04 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 12:12:36 UTC) #9
Message was sent while issue was closed. 
Change committed as 261366

Powered by Google App Engine
This is Rietveld 408576698