Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: content/renderer/service_worker/embedded_worker_context_client.cc

Issue 222833003: Remove irrelevant DCHECK that could hit (and it's ok) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/service_worker/embedded_worker_context_client.h" 5 #include "content/renderer/service_worker/embedded_worker_context_client.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "base/message_loop/message_loop_proxy.h" 8 #include "base/message_loop/message_loop_proxy.h"
9 #include "base/pickle.h" 9 #include "base/pickle.h"
10 #include "base/threading/thread_local.h" 10 #include "base/threading/thread_local.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 const GURL& script_url) 85 const GURL& script_url)
86 : embedded_worker_id_(embedded_worker_id), 86 : embedded_worker_id_(embedded_worker_id),
87 service_worker_version_id_(service_worker_version_id), 87 service_worker_version_id_(service_worker_version_id),
88 script_url_(script_url), 88 script_url_(script_url),
89 sender_(ChildThread::current()->thread_safe_sender()), 89 sender_(ChildThread::current()->thread_safe_sender()),
90 main_thread_proxy_(base::MessageLoopProxy::current()), 90 main_thread_proxy_(base::MessageLoopProxy::current()),
91 weak_factory_(this) { 91 weak_factory_(this) {
92 } 92 }
93 93
94 EmbeddedWorkerContextClient::~EmbeddedWorkerContextClient() { 94 EmbeddedWorkerContextClient::~EmbeddedWorkerContextClient() {
95 DCHECK(g_worker_client_tls.Pointer()->Get() != NULL); 95 // g_worker_client_tls.Pointer()->Get() could be NULL if this gets
96 // deleted before workerContextStarted() is called.
96 g_worker_client_tls.Pointer()->Set(NULL); 97 g_worker_client_tls.Pointer()->Set(NULL);
97 } 98 }
98 99
99 bool EmbeddedWorkerContextClient::OnMessageReceived( 100 bool EmbeddedWorkerContextClient::OnMessageReceived(
100 const IPC::Message& msg) { 101 const IPC::Message& msg) {
101 bool handled = true; 102 bool handled = true;
102 IPC_BEGIN_MESSAGE_MAP(EmbeddedWorkerContextClient, msg) 103 IPC_BEGIN_MESSAGE_MAP(EmbeddedWorkerContextClient, msg)
103 IPC_MESSAGE_HANDLER(EmbeddedWorkerContextMsg_SendMessageToWorker, 104 IPC_MESSAGE_HANDLER(EmbeddedWorkerContextMsg_SendMessageToWorker,
104 OnSendMessageToWorker) 105 OnSendMessageToWorker)
105 IPC_MESSAGE_UNHANDLED(handled = false) 106 IPC_MESSAGE_UNHANDLED(handled = false)
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 } 227 }
227 228
228 void EmbeddedWorkerContextClient::SendWorkerStarted() { 229 void EmbeddedWorkerContextClient::SendWorkerStarted() {
229 DCHECK(worker_task_runner_->RunsTasksOnCurrentThread()); 230 DCHECK(worker_task_runner_->RunsTasksOnCurrentThread());
230 sender_->Send(new EmbeddedWorkerHostMsg_WorkerStarted( 231 sender_->Send(new EmbeddedWorkerHostMsg_WorkerStarted(
231 WorkerTaskRunner::Instance()->CurrentWorkerId(), 232 WorkerTaskRunner::Instance()->CurrentWorkerId(),
232 embedded_worker_id_)); 233 embedded_worker_id_));
233 } 234 }
234 235
235 } // namespace content 236 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698