chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java - Issue 2228273002: Run ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() on Worker thread instead of IO thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java

Issue 2228273002: Run ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() on Worker thread instead of IO thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_builder_impl2_thread Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java

index b4b6564a18356665526b7a973bbf3f694cc92ad9..70bcb192a3c2c5009b63762365783a76518f5d63 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java

@@ -11,6 +11,7 @@ import android.content.Context;

import android.content.Intent;

import android.content.SharedPreferences;

import android.graphics.Bitmap;

+import android.os.AsyncTask;

import org.chromium.base.test.util.Feature;

import org.chromium.blink_public.platform.WebDisplayMode;

@@ -245,9 +246,15 @@ public class WebappDataStorageTest {

final long themeColor = 2;

final long backgroundColor = 3;

final boolean isIconGenerated = false;

- Intent shortcutIntent = ShortcutHelper.createWebappShortcutIntent(id, action, url, scope,

- name, shortName, icon, ShortcutHelper.WEBAPP_SHORTCUT_VERSION, displayMode,

- orientation, themeColor, backgroundColor, isIconGenerated);

+ AsyncTask<Void, Void, Intent> shortcutIntentTask = new AsyncTask<Void, Void, Intent>() {

+ @Override

+ protected Intent doInBackground(Void... nothing) {

+ return ShortcutHelper.createWebappShortcutIntent(id, action, url, scope, name,

+ shortName, icon, ShortcutHelper.WEBAPP_SHORTCUT_VERSION, displayMode,

+ orientation, themeColor, backgroundColor, isIconGenerated);

+ }

+ };

+ Intent shortcutIntent = shortcutIntentTask.execute().get();

WebappDataStorage storage = WebappDataStorage.open(Robolectric.application, "test");

storage.updateFromShortcutIntent(shortcutIntent);