Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1573)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java

Issue 2228273002: Run ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() on Worker thread instead of IO thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_builder_impl2_thread Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
index 8689b50062cfee8ef38868831f93586a002e3e79..d9803fd1fbf0cd5e34e15055947f9c27d35fef7b 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
@@ -4,6 +4,8 @@
package org.chromium.chrome.browser.preferences.privacy;
+import android.content.Intent;
+import android.os.AsyncTask;
import android.os.Environment;
import android.preference.CheckBoxPreference;
import android.preference.Preference;
@@ -143,13 +145,19 @@ public class ClearBrowsingDataPreferencesTest
*/
@MediumTest
public void testClearingHistoryClearsWebappScopesAndLaunchTimes() throws Exception {
+ AsyncTask<Void, Void, Intent> shortcutIntentTask = new AsyncTask<Void, Void, Intent>() {
+ @Override
+ protected Intent doInBackground(Void... nothing) {
+ return ShortcutHelper.createWebappShortcutIntentForTesting("id", "url");
+ }
+ };
+ final Intent shortcutIntent = shortcutIntentTask.execute().get();
+
WebappRegistry.registerWebapp(getActivity(), "first",
new WebappRegistry.FetchWebappDataStorageCallback() {
@Override
public void onWebappDataStorageRetrieved(WebappDataStorage storage) {
- storage.updateFromShortcutIntent(ShortcutHelper.createWebappShortcutIntent(
- "id", "action", "url", "scope", "name", "shortName", null,
- ShortcutHelper.WEBAPP_SHORTCUT_VERSION, 0, 0, 0, 0, false));
+ storage.updateFromShortcutIntent(shortcutIntent);
mCallbackCalled = true;
}
}

Powered by Google App Engine
This is Rietveld 408576698