Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2228253002: NQE: Remove Broadband from the list of ECT enums (Closed)

Created:
4 years, 4 months ago by tbansal1
Modified:
4 years, 4 months ago
Reviewers:
bengr
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, blink-reviews-api_chromium.org, nasko, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NQE: Remove Broadband from the list of ECT enums Currently, there are no plans to report EFFECTIVE_CONNECTION_TYPE_BROADBAND as a possible Effective Connection Type (ECT) from the Network Quality Estimator's (NQE) APIs. This CL removes EFFECTIVE_CONNECTION_TYPE_BROADBAND from the list of ECT enums. BUG=636187 TBR=nasko@chromium.org, japhet@chromium.org Committed: https://crrev.com/43b6c15a8f16bcbed01b3eb34bd9d656fde0c20b Cr-Commit-Position: refs/heads/master@{#411996}

Patch Set 1 #

Patch Set 2 : More cleanup #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -52 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/effective_connection_type_helper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/nqe/effective_connection_type.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M net/nqe/effective_connection_type.cc View 1 2 3 chunks +0 lines, -7 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 1 2 16 chunks +27 lines, -35 lines 0 comments Download
M third_party/WebKit/public/platform/WebEffectiveConnectionType.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 35 (27 generated)
tbansal1
bengr: ptal. Thanks.
4 years, 4 months ago (2016-08-10 01:09:56 UTC) #7
bengr
lgtm
4 years, 4 months ago (2016-08-12 18:53:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228253002/60001
4 years, 4 months ago (2016-08-15 18:17:42 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/238152)
4 years, 4 months ago (2016-08-15 18:23:49 UTC) #27
tbansal1
TBR'ing nasko@chromium.org, japhet@chromium.org since the changes in the related files are mechanical.
4 years, 4 months ago (2016-08-15 18:26:26 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228253002/60001
4 years, 4 months ago (2016-08-15 18:27:05 UTC) #31
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-15 18:36:10 UTC) #33
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 18:41:39 UTC) #35
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/43b6c15a8f16bcbed01b3eb34bd9d656fde0c20b
Cr-Commit-Position: refs/heads/master@{#411996}

Powered by Google App Engine
This is Rietveld 408576698