Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: net/nqe/effective_connection_type.cc

Issue 2228253002: NQE: Remove Broadband from the list of ECT enums (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/nqe/effective_connection_type.h ('k') | net/nqe/network_quality_estimator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/effective_connection_type.cc
diff --git a/net/nqe/effective_connection_type.cc b/net/nqe/effective_connection_type.cc
index 2996cb10129cb7a78f5344c1b7681d813e53e21b..94908d4c0460ece02262efbce963caea3344535e 100644
--- a/net/nqe/effective_connection_type.cc
+++ b/net/nqe/effective_connection_type.cc
@@ -14,7 +14,6 @@ const char kEffectiveConnectionTypeSlow2G[] = "Slow2G";
const char kEffectiveConnectionType2G[] = "2G";
const char kEffectiveConnectionType3G[] = "3G";
const char kEffectiveConnectionType4G[] = "4G";
-const char kEffectiveConnectionTypeBroadband[] = "Broadband";
} // namespace
@@ -34,8 +33,6 @@ const char* GetNameForEffectiveConnectionType(EffectiveConnectionType type) {
return kEffectiveConnectionType3G;
case EFFECTIVE_CONNECTION_TYPE_4G:
return kEffectiveConnectionType4G;
- case EFFECTIVE_CONNECTION_TYPE_BROADBAND:
- return kEffectiveConnectionTypeBroadband;
default:
NOTREACHED();
break;
@@ -70,10 +67,6 @@ bool GetEffectiveConnectionTypeForName(
*effective_connection_type = EFFECTIVE_CONNECTION_TYPE_4G;
return true;
}
- if (connection_type_name == kEffectiveConnectionTypeBroadband) {
- *effective_connection_type = EFFECTIVE_CONNECTION_TYPE_BROADBAND;
- return true;
- }
*effective_connection_type = EFFECTIVE_CONNECTION_TYPE_UNKNOWN;
return false;
}
« no previous file with comments | « net/nqe/effective_connection_type.h ('k') | net/nqe/network_quality_estimator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698