Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2227983003: Restore scratch texture reuse on Adreno. (Closed)

Created:
4 years, 4 months ago by Brian Osman
Modified:
4 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Restore scratch texture reuse on Adreno. New testing shows that it's a win on our slowest SKPs, and pretty much a wash on faster tests (mixed results). However, it also saves us ~3 ms on the hwui bitmap upload jank test. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2227983003 Committed: https://skia.googlesource.com/skia/+/5702c861c487ce93bce3b96db92b2c5a250f758a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Brian Osman
I went through the history of this flag, and it appears to always have been ...
4 years, 4 months ago (2016-08-09 20:11:34 UTC) #5
bsalomon
lgtm
4 years, 4 months ago (2016-08-09 20:13:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227983003/1
4 years, 4 months ago (2016-08-09 20:49:21 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 21:02:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5702c861c487ce93bce3b96db92b2c5a250f758a

Powered by Google App Engine
This is Rietveld 408576698