Use smart pointers for class owned pointers in xfa/fxfa

Use smart pointers for class owned pointers in xfa/fxfa

Use smart pointers instead of raw pointer to make memory management
easier for classes mainly under xfa/fxfa.

Also change the return type of IFGAS_FontMgr::Create() to smart
pointer type.

BUG=pdfium:518
Committed: https://pdfium.googlesource.com/pdfium/+/b4d1b576bccb5ca6cebe29288af014bd0f512af1

[Wei Li, 2016-08-09 00:30:02]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 00:30:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 00:33:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 00:33:01]

Dry run: Try jobs failed on following builders:
  mac_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa/builds/...)

[Wei Li, 2016-08-09 19:53:46]

Patchset #4 (id:60001) has been deleted

[Wei Li, 2016-08-10 05:56:48]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 05:57:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 06:09:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 06:09:12]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-10 06:33:58]

Patchset #7 (id:140001) has been deleted

[Wei Li, 2016-08-10 06:34:11]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 06:34:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 06:43:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 06:43:31]

Dry run: Try jobs failed on following builders:
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Wei Li, 2016-08-10 06:46:17]

Patchset #7 (id:160001) has been deleted

[Wei Li, 2016-08-10 06:46:28]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 06:46:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 07:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 07:07:01]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-10 19:10:43]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-08-10 19:10:44]

pls review, thanks

[dsinclair, 2016-08-10 19:47:25]

lgtm w/ a couple questions.

https://codereview.chromium.org/2227883002/diff/180001/xfa/fxfa/include/xfa_f...
File xfa/fxfa/include/xfa_ffdocview.h (right):

https://codereview.chromium.org/2227883002/diff/180001/xfa/fxfa/include/xfa_f...
xfa/fxfa/include/xfa_ffdocview.h:120: CXFA_FFWidget* m_pOldFocusWidget;
Are the above not owned? Or can they be unique_ptr?

https://codereview.chromium.org/2227883002/diff/180001/xfa/fxfa/include/xfa_f...
xfa/fxfa/include/xfa_ffdocview.h:149: CXFA_WidgetAcc* m_pCurWidgetAcc;
Can this be unique_ptr or is it not owned?

https://codereview.chromium.org/2227883002/diff/180001/xfa/fxfa/parser/xfa_lo...
File xfa/fxfa/parser/xfa_localemgr.cpp (right):

https://codereview.chromium.org/2227883002/diff/180001/xfa/fxfa/parser/xfa_lo...
xfa/fxfa/parser/xfa_localemgr.cpp:1036: static IFX_Locale*
XFA_GetLocaleFromBuffer(const uint8_t* pBuf, int nBufLen) {
Should this return a unique_ptr? (possibly as a followup)

[Wei Li, 2016-08-10 21:34:05]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 21:34:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wei Li, 2016-08-10 21:44:58]

thanks

https://codereview.chromium.org/2227883002/diff/180001/xfa/fxfa/include/xfa_f...
File xfa/fxfa/include/xfa_ffdocview.h (right):

https://codereview.chromium.org/2227883002/diff/180001/xfa/fxfa/include/xfa_f...
xfa/fxfa/include/xfa_ffdocview.h:120: CXFA_FFWidget* m_pOldFocusWidget;
On 2016/08/10 19:47:25, dsinclair wrote:
> Are the above not owned? Or can they be unique_ptr?

they are not owned by this class. Marked them explicitly.

https://codereview.chromium.org/2227883002/diff/180001/xfa/fxfa/include/xfa_f...
xfa/fxfa/include/xfa_ffdocview.h:149: CXFA_WidgetAcc* m_pCurWidgetAcc;
On 2016/08/10 19:47:25, dsinclair wrote:
> Can this be unique_ptr or is it not owned?

Not owned.

https://codereview.chromium.org/2227883002/diff/180001/xfa/fxfa/parser/xfa_lo...
File xfa/fxfa/parser/xfa_localemgr.cpp (right):

https://codereview.chromium.org/2227883002/diff/180001/xfa/fxfa/parser/xfa_lo...
xfa/fxfa/parser/xfa_localemgr.cpp:1036: static IFX_Locale*
XFA_GetLocaleFromBuffer(const uint8_t* pBuf, int nBufLen) {
On 2016/08/10 19:47:25, dsinclair wrote:
> Should this return a unique_ptr? (possibly as a followup)

Add a TODO to followup.

[commit-bot: I haz the power, 2016-08-10 21:49:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 21:49:42]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-10 21:50:26]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-08-10 21:50:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2227883002/#ps220001
(title: "address comments")

[commit-bot: I haz the power, 2016-08-10 21:50:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 21:50:52]

Description was changed from

==========
Use smart pointers for class owned pointers in xfa/fxfa

Use smart pointers instead of raw pointer to make memory management
easier for classes mainly under xfa/fxfa.

Also change the return type of IFGAS_FontMgr::Create() to smart
pointer type.

BUG=pdfium:518
==========

to

==========
Use smart pointers for class owned pointers in xfa/fxfa

Use smart pointers instead of raw pointer to make memory management
easier for classes mainly under xfa/fxfa.

Also change the return type of IFGAS_FontMgr::Create() to smart
pointer type.

BUG=pdfium:518

Committed:
https://pdfium.googlesource.com/pdfium/+/b4d1b576bccb5ca6cebe29288af014bd0f51...
==========

[commit-bot: I haz the power, 2016-08-10 21:50:55]

Committed patchset #9 (id:220001) as
https://pdfium.googlesource.com/pdfium/+/b4d1b576bccb5ca6cebe29288af014bd0f51...