Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: xfa/fxfa/parser/cxfa_resolveprocessor.cpp

Issue 2227883002: Use smart pointers for class owned pointers in xfa/fxfa (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxfa/parser/cxfa_resolveprocessor.h ('k') | xfa/fxfa/parser/xfa_locale.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fxfa/parser/cxfa_resolveprocessor.h" 7 #include "xfa/fxfa/parser/cxfa_resolveprocessor.h"
8 8
9 #include "core/fxcrt/include/fx_ext.h" 9 #include "core/fxcrt/include/fx_ext.h"
10 #include "xfa/fxfa/parser/cxfa_document.h" 10 #include "xfa/fxfa/parser/cxfa_document.h"
11 #include "xfa/fxfa/parser/cxfa_nodehelper.h" 11 #include "xfa/fxfa/parser/cxfa_nodehelper.h"
12 #include "xfa/fxfa/parser/cxfa_scriptcontext.h" 12 #include "xfa/fxfa/parser/cxfa_scriptcontext.h"
13 #include "xfa/fxfa/parser/xfa_localemgr.h" 13 #include "xfa/fxfa/parser/xfa_localemgr.h"
14 #include "xfa/fxfa/parser/xfa_object.h" 14 #include "xfa/fxfa/parser/xfa_object.h"
15 #include "xfa/fxfa/parser/xfa_resolvenode_rs.h" 15 #include "xfa/fxfa/parser/xfa_resolvenode_rs.h"
16 #include "xfa/fxfa/parser/xfa_utils.h" 16 #include "xfa/fxfa/parser/xfa_utils.h"
17 17
18 CXFA_ResolveProcessor::CXFA_ResolveProcessor() 18 CXFA_ResolveProcessor::CXFA_ResolveProcessor()
19 : m_iCurStart(0), m_pNodeHelper(new CXFA_NodeHelper) {} 19 : m_iCurStart(0), m_pNodeHelper(new CXFA_NodeHelper) {}
20 20
21 CXFA_ResolveProcessor::~CXFA_ResolveProcessor() { 21 CXFA_ResolveProcessor::~CXFA_ResolveProcessor() {}
22 delete m_pNodeHelper;
23 }
24 22
25 int32_t CXFA_ResolveProcessor::Resolve(CXFA_ResolveNodesData& rnd) { 23 int32_t CXFA_ResolveProcessor::Resolve(CXFA_ResolveNodesData& rnd) {
26 if (!rnd.m_CurNode) { 24 if (!rnd.m_CurNode) {
27 return -1; 25 return -1;
28 } 26 }
29 if (!rnd.m_CurNode->IsNode()) { 27 if (!rnd.m_CurNode->IsNode()) {
30 if (rnd.m_dwStyles & XFA_RESOLVENODE_Attributes) { 28 if (rnd.m_dwStyles & XFA_RESOLVENODE_Attributes) {
31 return ResolveForAttributeRs(rnd.m_CurNode, rnd, 29 return ResolveForAttributeRs(rnd.m_CurNode, rnd,
32 rnd.m_wsName.AsStringC()); 30 rnd.m_wsName.AsStringC());
33 } 31 }
(...skipping 782 matching lines...) Expand 10 before | Expand all | Expand 10 after
816 m_wsCondition(), 814 m_wsCondition(),
817 m_nLevel(0), 815 m_nLevel(0),
818 m_Nodes(), 816 m_Nodes(),
819 m_dwStyles(XFA_RESOLVENODE_Children), 817 m_dwStyles(XFA_RESOLVENODE_Children),
820 m_pScriptAttribute(nullptr), 818 m_pScriptAttribute(nullptr),
821 m_dwFlag(XFA_RESOVENODE_RSTYPE_Nodes) {} 819 m_dwFlag(XFA_RESOVENODE_RSTYPE_Nodes) {}
822 820
823 CXFA_ResolveNodesData::~CXFA_ResolveNodesData() { 821 CXFA_ResolveNodesData::~CXFA_ResolveNodesData() {
824 m_Nodes.RemoveAll(); 822 m_Nodes.RemoveAll();
825 } 823 }
OLDNEW
« no previous file with comments | « xfa/fxfa/parser/cxfa_resolveprocessor.h ('k') | xfa/fxfa/parser/xfa_locale.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698