Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 222783004: Move textual replacement to WebContents. (Closed)

Created:
6 years, 8 months ago by Avi (use Gerrit)
Modified:
6 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Move textual replacement to WebContents. BUG=304341 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -52 lines) Patch
M chrome/browser/renderer_context_menu/spelling_menu_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +22 lines, -1 line 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +9 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
6 years, 8 months ago (2014-04-02 22:00:27 UTC) #1
jam
lgtm
6 years, 8 months ago (2014-04-02 23:42:06 UTC) #2
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-03 02:20:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/222783004/1
6 years, 8 months ago (2014-04-03 02:25:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 10:12:30 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 10:12:31 UTC) #6
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 8 months ago (2014-04-03 14:29:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/222783004/1
6 years, 8 months ago (2014-04-03 14:30:23 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 14:50:29 UTC) #9
Message was sent while issue was closed.
Change committed as 261384

Powered by Google App Engine
This is Rietveld 408576698