chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm - Issue 222783004: Move textual replacement to WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

Issue 222783004: Move textual replacement to WebContents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_context_menu/spelling_menu_observer.cc ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

diff --git a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

index 6a2efbf2332a4684dd829ddd2926677c9c0e1763..a6b260fbd4a75905f18e445f9faf1c151f3e5931 100644

--- a/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

+++ b/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

@@ -218,7 +218,10 @@ class SpellCheckObserver : public content::WebContentsObserver {

// that we want to replace the selected word in the text with.

NSString* newWord = [[sender selectedCell] stringValue];

if (newWord != nil) {

- renderWidgetHost_->Replace(base::SysNSStringToUTF16(newWord));

+ content::WebContents* webContents =

+ content::WebContents::FromRenderViewHost(

+ RenderViewHost::From(renderWidgetHost_));

+ webContents->Replace(base::SysNSStringToUTF16(newWord));

}