src/full-codegen/ia32/full-codegen-ia32.cc - Issue 2227763003: [turbofan] Rewrite ToObject as TurboFan stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2227763003: [turbofan] Rewrite ToObject as TurboFan stub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add comment with ES6 section Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 1620905a77c60732acd35558cf2ea3769e3c2bd0..44f72e49493de32f883cf557c7b41372d89e535e 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -945,8 +945,10 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

__ cmp(eax, isolate()->factory()->null_value());

__ j(equal, &exit);

__ bind(&convert);

+ __ Push(esi);

ToObjectStub stub(isolate());

__ CallStub(&stub);

+ __ Pop(esi);

__ bind(&done_convert);

PrepareForBailoutForId(stmt->ToObjectId(), BailoutState::TOS_REGISTER);

__ push(eax);