src/full-codegen/full-codegen.cc - Issue 2227763003: [turbofan] Rewrite ToObject as TurboFan stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 2227763003: [turbofan] Rewrite ToObject as TurboFan stub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add comment with ES6 section Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index 6a583a2ccd667e3bf98a1858ca67a0fd2051ec9c..08ad2d80b198f5f1fe4961fd590afbebeed0a6bf 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -1067,8 +1067,10 @@ void FullCodeGenerator::VisitWithStatement(WithStatement* stmt) {

VisitForAccumulatorValue(stmt->expression());

Callable callable = CodeFactory::ToObject(isolate());

+ __ Push(context_register());

__ Move(callable.descriptor().GetRegisterParameter(0), result_register());

__ Call(callable.code(), RelocInfo::CODE_TARGET);

+ __ Pop(context_register());

Michael Starzinger 2016/08/09 10:24:29 Please use FullCodeGenerator::RestoreContext after

Franzi 2016/08/09 11:21:38 Done.

PrepareForBailoutForId(stmt->ToObjectId(), BailoutState::TOS_REGISTER);

PushOperand(result_register());

PushFunctionArgumentForContextAllocation();