Remove backpointer to CJS_Runtime from CJS_Value

Remove backpointer to CJS_Runtime from CJS_Value

Committed: https://pdfium.googlesource.com/pdfium/+/f3dc8c6941635e5c4cc20c8388289f6b148dc9eb

[Tom Sepez, 2016-08-09 18:50:43]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 18:50:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-09 18:51:42]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-08-09 18:51:43]

Dan, for review.  This one gets a little more involved.

[commit-bot: I haz the power, 2016-08-09 18:52:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 18:52:04]

Dry run: Try jobs failed on following builders:
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)

[Tom Sepez, 2016-08-09 18:58:59]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 18:59:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 19:22:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 19:22:35]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-08-09 19:25:34]

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
File fpdfsdk/javascript/Document.cpp (left):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1047: vRet = CJS_Value::VT_undefined;
Is this no longer needed?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
File fpdfsdk/javascript/Document.cpp (right):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:285: CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
Move 285 and 286 down to 293 where they're first needed?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:303: FXJS_NewFxDynamicObj(pIsolate, pRuntime,
CJS_Field::g_nObjDefnID);
Does this always take the isolate from the runtime? Or, can the isolate differ
from pRuntime->GetIsolate() in other calls? If it doesn't differ, can we just
remove the isolate param?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:305: CJS_Field* pJSField =
(CJS_Field*)FXJS_GetPrivate(pIsolate, pFieldObj);
static_cast

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:306: Field* pField =
(Field*)pJSField->GetEmbedObject();
static_cast

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:319: CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
Down to 327?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:380: v8::Isolate* pIsolate =
pRuntime->GetIsolate();
Down to 387

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:401: CPDFDoc_Environment* pEnv =
pContext->GetReaderApp();
This was outside the Begin/End block previously, not sure the ramifications,
does it matter?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:483: v8::Isolate* pIsolate =
pRuntime->GetIsolate();
Move to 488?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:531: v8::Isolate* pIsolate =
pRuntime->GetIsolate();
Move to 548?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:587: CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
Move to 596?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:681: CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
...

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1091: CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
...

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1126: CJS_Runtime* pRuntime =
CJS_Runtime::FromContext(cc);
...

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1170: CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
...

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1256: CJS_Context* pContext =
static_cast<CJS_Context*>(cc);
...

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1322: v8::Isolate* pIsolate =
pRuntime->GetIsolate();
...

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1505: CJS_Runtime* runtime =
context->GetJSRuntime();
...

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
File fpdfsdk/javascript/Field.cpp (left):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:3056: vRet = FALSE;
Not needed?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:3182: vRet = FALSE;
Not needed?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:3213: vRet = FALSE;
...

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
File fpdfsdk/javascript/Field.cpp (right):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:2101: pArray[3] =
(FX_FLOAT)Upper_Lefty.ToInt(pRuntime->GetIsolate());
static_cast?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:2122: Upper_Leftx = CJS_Value(pRuntime,
(int32_t)crRect.left);
static_cast? (and below)

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:2745: .c_str()) == 0)
nit: {}'s

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:3001: CJS_Runtime* pRuntime =
CJS_Runtime::FromContext(cc);
...

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:3049: CJS_Runtime* pRuntime =
CJS_Runtime::FromContext(cc);
...

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
File fpdfsdk/javascript/JS_Value.cpp (right):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
fpdfsdk/javascript/JS_Value.cpp:83: int CJS_Value::ToInt(v8::Isolate* pIsolate)
const {
Why not store the isolate in the constructor? Just to keep things nicely
separated in case the original isolate is different from the current one?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
fpdfsdk/javascript/JS_Value.cpp:194: CJS_PropValue::CJS_PropValue(CJS_Runtime*
pRuntime)
It looks like, if the CJS_Value is changed to take the isolate, this could also
change to take the isolate.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
File fpdfsdk/javascript/JS_Value.h (right):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
fpdfsdk/javascript/JS_Value.h:35: CJS_Value(CJS_Runtime* pRuntime,
v8::Local<v8::Value> pValue);
These can also just take the isolate? (possibly a follow up?)

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
fpdfsdk/javascript/JS_Value.h:50: void SetNull(CJS_Runtime* pRuntime);
It looks like this just uses hte pRuntime to get the isolate, can we change it
to take the v8::Isolate to match all of the other methods?

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Publ...
File fpdfsdk/javascript/PublicMethods.cpp (right):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Publ...
fpdfsdk/javascript/PublicMethods.cpp:1629: pRuntime, (double)AF_Simple(
static_cast

[Tom Sepez, 2016-08-09 20:33:25]

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
File fpdfsdk/javascript/Document.cpp (left):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1047: vRet = CJS_Value::VT_undefined;
On 2016/08/09 19:25:32, dsinclair wrote:
> Is this no longer needed?
It was wrong.  Not setting a value results in JS getting |undefined|.  This was
returning an integer whose value happened to be whatever constant we assigned to
the enum.  Not very useful.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
File fpdfsdk/javascript/Document.cpp (right):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:285: CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
On 2016/08/09 19:25:33, dsinclair wrote:
> Move 285 and 286 down to 293 where they're first needed?

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:303: FXJS_NewFxDynamicObj(pIsolate, pRuntime,
CJS_Field::g_nObjDefnID);
On 2016/08/09 19:25:32, dsinclair wrote:
> Does this always take the isolate from the runtime? Or, can the isolate differ
> from pRuntime->GetIsolate() in other calls? If it doesn't differ, can we just
> remove the isolate param?

That's a follow-on.  Ideally, there'd be a CFXJS_Runtime from which CJS_Runtime
inherits.  Then this call becomes 

foo = pRuntime->NewFxDynamicObject(id);

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:305: CJS_Field* pJSField =
(CJS_Field*)FXJS_GetPrivate(pIsolate, pFieldObj);
On 2016/08/09 19:25:32, dsinclair wrote:
> static_cast

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:306: Field* pField =
(Field*)pJSField->GetEmbedObject();
On 2016/08/09 19:25:32, dsinclair wrote:
> static_cast

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:319: CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
On 2016/08/09 19:25:32, dsinclair wrote:
> Down to 327?

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:380: v8::Isolate* pIsolate =
pRuntime->GetIsolate();
On 2016/08/09 19:25:32, dsinclair wrote:
> Down to 387

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:401: CPDFDoc_Environment* pEnv =
pContext->GetReaderApp();
On 2016/08/09 19:25:32, dsinclair wrote:
> This was outside the Begin/End block previously, not sure the ramifications,
> does it matter?

Nope, it just guards against re-entrancy in the embedder callbacks.  If we're
not going to make the call, nothing to guard.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:483: v8::Isolate* pIsolate =
pRuntime->GetIsolate();
On 2016/08/09 19:25:32, dsinclair wrote:
> Move to 488?

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:531: v8::Isolate* pIsolate =
pRuntime->GetIsolate();
On 2016/08/09 19:25:32, dsinclair wrote:
> Move to 548?

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:587: CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
On 2016/08/09 19:25:32, dsinclair wrote:
> Move to 596?

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:681: CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
On 2016/08/09 19:25:33, dsinclair wrote:
> ...

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1091: CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
On 2016/08/09 19:25:32, dsinclair wrote:
> ...

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1126: CJS_Runtime* pRuntime =
CJS_Runtime::FromContext(cc);
On 2016/08/09 19:25:32, dsinclair wrote:
> ...

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1170: CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
On 2016/08/09 19:25:32, dsinclair wrote:
> ...

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1256: CJS_Context* pContext =
static_cast<CJS_Context*>(cc);
On 2016/08/09 19:25:32, dsinclair wrote:
> ...

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1322: v8::Isolate* pIsolate =
pRuntime->GetIsolate();
On 2016/08/09 19:25:33, dsinclair wrote:
> ...

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Docu...
fpdfsdk/javascript/Document.cpp:1505: CJS_Runtime* runtime =
context->GetJSRuntime();
On 2016/08/09 19:25:32, dsinclair wrote:
> ...

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
File fpdfsdk/javascript/Field.cpp (left):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:3056: vRet = FALSE;
On 2016/08/09 19:25:33, dsinclair wrote:
> Not needed?

When we return false, JS throws an execption, and the returned value isn't used.
 The code should be specifiying an error via serror though ...

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:3182: vRet = FALSE;
On 2016/08/09 19:25:33, dsinclair wrote:
> Not needed?

See above.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:3213: vRet = FALSE;
On 2016/08/09 19:25:33, dsinclair wrote:
> ...

...

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
File fpdfsdk/javascript/Field.cpp (right):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:2101: pArray[3] =
(FX_FLOAT)Upper_Lefty.ToInt(pRuntime->GetIsolate());
On 2016/08/09 19:25:33, dsinclair wrote:
> static_cast?

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:2122: Upper_Leftx = CJS_Value(pRuntime,
(int32_t)crRect.left);
On 2016/08/09 19:25:33, dsinclair wrote:
> static_cast? (and below)

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:2745: .c_str()) == 0)
On 2016/08/09 19:25:33, dsinclair wrote:
> nit: {}'s

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:3001: CJS_Runtime* pRuntime =
CJS_Runtime::FromContext(cc);
On 2016/08/09 19:25:33, dsinclair wrote:
> ...

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Fiel...
fpdfsdk/javascript/Field.cpp:3049: CJS_Runtime* pRuntime =
CJS_Runtime::FromContext(cc);
On 2016/08/09 19:25:33, dsinclair wrote:
> ...

Done.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
File fpdfsdk/javascript/JS_Value.cpp (right):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
fpdfsdk/javascript/JS_Value.cpp:83: int CJS_Value::ToInt(v8::Isolate* pIsolate)
const {
On 2016/08/09 19:25:33, dsinclair wrote:
> Why not store the isolate in the constructor? Just to keep things nicely
> separated in case the original isolate is different from the current one?

Nah, I want to get to a point where a CJS_Value only contains a v8::Value.  Then
CJS_Value can get replaced entirely with v8::Value throughout the code base.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
fpdfsdk/javascript/JS_Value.cpp:194: CJS_PropValue::CJS_PropValue(CJS_Runtime*
pRuntime)
On 2016/08/09 19:25:33, dsinclair wrote:
> It looks like, if the CJS_Value is changed to take the isolate, this could
also
> change to take the isolate.

Yeah, same deal.

The propvalue isn't a real value per-se, but rather an aggregate to make passing
args easier, it should store the runtime.  runtime => isolate easy, isolate =>
runtime involves going thru V8 embedder slots.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
File fpdfsdk/javascript/JS_Value.h (right):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
fpdfsdk/javascript/JS_Value.h:35: CJS_Value(CJS_Runtime* pRuntime,
v8::Local<v8::Value> pValue);
On 2016/08/09 19:25:33, dsinclair wrote:
> These can also just take the isolate? (possibly a follow up?)

Actually, all of these should just take the CJS_Runtime.  Follow-up.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
fpdfsdk/javascript/JS_Value.h:50: void SetNull(CJS_Runtime* pRuntime);
On 2016/08/09 19:25:33, dsinclair wrote:
> It looks like this just uses hte pRuntime to get the isolate, can we change it
> to take the v8::Isolate to match all of the other methods?

Actually, this is closer to one of the CTOR's above, except we don't
have a type that represents null very well to use for type deductions (  Using
nullptr_t would flip folks out, I think).  So the argument is closer to what the
CTOR takes.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/JS_V...
fpdfsdk/javascript/JS_Value.h:58: int ToInt(v8::Isolate* pIsolate) const;
These should be the ones that change, but I don't have the CJS_Runtime in all
places just yet.

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Publ...
File fpdfsdk/javascript/PublicMethods.cpp (right):

https://codereview.chromium.org/2227673005/diff/40001/fpdfsdk/javascript/Publ...
fpdfsdk/javascript/PublicMethods.cpp:1629: pRuntime, (double)AF_Simple(
On 2016/08/09 19:25:33, dsinclair wrote:
> static_cast

Done.

[Tom Sepez, 2016-08-09 20:33:51]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 20:33:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:45:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 20:45:26]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-08-10 13:17:48]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-08-10 13:17:49]

lgtm

[commit-bot: I haz the power, 2016-08-10 13:17:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 13:29:34]

Description was changed from

==========
Remove backpointer to CJS_Runtime from CJS_Value
==========

to

==========
Remove backpointer to CJS_Runtime from CJS_Value

Committed:
https://pdfium.googlesource.com/pdfium/+/f3dc8c6941635e5c4cc20c8388289f6b148d...
==========

[commit-bot: I haz the power, 2016-08-10 13:29:35]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/f3dc8c6941635e5c4cc20c8388289f6b148d...