fpdfsdk/javascript/event.cpp - Issue 2227673005: Remove backpointer to CJS_Runtime from CJS_Value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/event.cpp

Issue 2227673005: Remove backpointer to CJS_Runtime from CJS_Value (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Const member Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/event.cpp

diff --git a/fpdfsdk/javascript/event.cpp b/fpdfsdk/javascript/event.cpp

index 253a802c8fb89a56c152542488db914ef2e975ed..880247f2498cc6ebe90fa47a3dcd5a8614416d84 100644

--- a/fpdfsdk/javascript/event.cpp

+++ b/fpdfsdk/javascript/event.cpp

@@ -55,7 +55,7 @@ FX_BOOL event::change(IJS_Context* cc,

CJS_EventHandler* pEvent = pContext->GetEventHandler();

CFX_WideString& wChange = pEvent->Change();

if (vp.IsSetting()) {

- if (vp.GetType() == CJS_Value::VT_string)

+ if (vp.GetJSValue()->GetType() == CJS_Value::VT_string)

vp >> wChange;

} else {

vp << wChange;

« no previous file with comments | « fpdfsdk/javascript/color.cpp ('k') | fpdfsdk/javascript/global.cpp » ('j') | no next file with comments »