Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2227673002: std::move(SkTDArray) (Closed)

Created:
4 years, 4 months ago by hal.canary
Modified:
4 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

std::move(SkTDArray) Since we don't support MSVC2013 anymore, we can be more succinct when defining move constructors of compound types. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2227673002 Committed: https://skia.googlesource.com/skia/+/9be372041ec331f1b04c99890f92d24c59bf9dad

Patch Set 1 #

Patch Set 2 : 2016-08-08 (Monday) 09:19:06 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -51 lines) Patch
M include/private/SkTDArray.h View 3 chunks +12 lines, -7 lines 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.h View 1 chunk +2 lines, -13 lines 0 comments Download
M src/pdf/SkPDFDevice.h View 2 chunks +4 lines, -14 lines 0 comments Download
M src/pdf/SkPDFTypes.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/utils/SkMultiPictureDocument.cpp View 1 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
hal.canary
PTAL
4 years, 4 months ago (2016-08-08 13:34:14 UTC) #6
bungeman-skia
lgtm
4 years, 4 months ago (2016-08-08 13:58:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227673002/20001
4 years, 4 months ago (2016-08-08 14:03:17 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 14:21:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9be372041ec331f1b04c99890f92d24c59bf9dad

Powered by Google App Engine
This is Rietveld 408576698