Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: src/pdf/SkPDFDevice.h

Issue 2227673002: std::move(SkTDArray) (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: 2016-08-08 (Monday) 09:19:06 EDT Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkAdvancedTypefaceMetrics.h ('k') | src/pdf/SkPDFTypes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pdf/SkPDFDevice.h
diff --git a/src/pdf/SkPDFDevice.h b/src/pdf/SkPDFDevice.h
index 5fedd0eb4ce231758af2edf8b0da4a95d3599c21..74047521c5a4d7bb90950279cac59df30aa568dd 100644
--- a/src/pdf/SkPDFDevice.h
+++ b/src/pdf/SkPDFDevice.h
@@ -206,13 +206,8 @@ private:
sk_sp<SkData> data;
RectWithData(const SkRect& rect, SkData* data)
: rect(rect), data(SkRef(data)) {}
- RectWithData(RectWithData&& other)
- : rect(other.rect), data(std::move(other.data)) {}
- RectWithData& operator=(RectWithData&& other) {
- rect = other.rect;
- data = std::move(other.data);
- return *this;
- }
+ RectWithData(RectWithData&&) = default;
+ RectWithData& operator=(RectWithData&& other) = default;
};
struct NamedDestination {
@@ -220,13 +215,8 @@ private:
SkPoint point;
NamedDestination(SkData* nameData, const SkPoint& point)
: nameData(SkRef(nameData)), point(point) {}
- NamedDestination(NamedDestination&& other)
- : nameData(std::move(other.nameData)), point(other.point) {}
- NamedDestination& operator=(NamedDestination&& other) {
- nameData = std::move(other.nameData);
- point = other.point;
- return *this;
- }
+ NamedDestination(NamedDestination&&) = default;
+ NamedDestination& operator=(NamedDestination&&) = default;
};
// TODO(vandebo): push most of SkPDFDevice's state into a core object in
« no previous file with comments | « src/core/SkAdvancedTypefaceMetrics.h ('k') | src/pdf/SkPDFTypes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698