Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: content/browser/service_worker/embedded_worker_instance.h

Issue 2227593002: ServiceWorker: Implement StartWorker by using mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added argument check and updated comment and BUILD.gn Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_instance.h
diff --git a/content/browser/service_worker/embedded_worker_instance.h b/content/browser/service_worker/embedded_worker_instance.h
index 116456b4528ccafdd3f830da61a1b9cce0df1b2f..607a8c5c4f4c30e9371af11103526158cd8aa07a 100644
--- a/content/browser/service_worker/embedded_worker_instance.h
+++ b/content/browser/service_worker/embedded_worker_instance.h
@@ -23,6 +23,7 @@
#include "content/browser/service_worker/embedded_worker_status.h"
#include "content/browser/service_worker/service_worker_metrics.h"
#include "content/common/content_export.h"
+#include "content/common/service_worker/embedded_worker.mojom.h"
#include "content/common/service_worker/service_worker_status_code.h"
#include "content/public/common/console_message_level.h"
#include "url/gurl.h"
@@ -223,6 +224,10 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
int worker_devtools_agent_route_id,
bool wait_for_debugger);
+ // Sends StartWorker message via Mojo.
+ void SendMojoStartWorker(
+ std::unique_ptr<EmbeddedWorkerMsg_StartWorker_Params> params);
+
// Called back from StartTask after a start worker message is sent.
void OnStartWorkerMessageSent();
@@ -307,6 +312,7 @@ class CONTENT_EXPORT EmbeddedWorkerInstance {
int thread_id_;
std::unique_ptr<shell::InterfaceRegistry> interface_registry_;
std::unique_ptr<shell::InterfaceProvider> remote_interfaces_;
+ mojom::EmbeddedWorkerInstanceClientPtr instance_client_;
falken 2016/09/07 05:01:41 nit: Since this is a member of EmbeddedWorkerInsta
shimazu 2016/09/12 06:28:19 Done.
// Whether devtools is attached or not.
bool devtools_attached_;

Powered by Google App Engine
This is Rietveld 408576698