ServiceWorker: Implement StartWorker by using mojo

content/browser/service_worker/embedded_worker_instance.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_EMBEDDED_WORKER_INSTANCE_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_EMBEDDED_WORKER_INSTANCE_H_
 
 #include <stdint.h>
 
 #include <memory>
 #include <string>
 
 #include "base/callback.h"
 #include "base/callback_forward.h"
 #include "base/gtest_prod_util.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/observer_list.h"
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "content/browser/service_worker/embedded_worker_status.h"
 #include "content/browser/service_worker/service_worker_metrics.h"
 #include "content/common/content_export.h"
+#include "content/common/service_worker/embedded_worker.mojom.h"
 #include "content/common/service_worker/service_worker_status_code.h"
 #include "content/public/common/console_message_level.h"
 #include "url/gurl.h"
 
 // Windows headers will redefine SendMessage.
 #ifdef SendMessage
 #undef SendMessage
 #endif
 
 struct EmbeddedWorkerMsg_StartWorker_Params;
@@ skipping 180 matching lines @@
   // Called back from StartTask after a process is allocated on the UI thread.
   void OnProcessAllocated(std::unique_ptr<WorkerProcessHandle> handle,
                           ServiceWorkerMetrics::StartSituation start_situation);
 
   // Called back from StartTask after the worker is registered to
   // WorkerDevToolsManager.
   void OnRegisteredToDevToolsManager(bool is_new_process,
                                      int worker_devtools_agent_route_id,
                                      bool wait_for_debugger);
 
+  // Sends StartWorker message via Mojo.
+  void SendMojoStartWorker(
+      std::unique_ptr<EmbeddedWorkerMsg_StartWorker_Params> params);
+
   // Called back from StartTask after a start worker message is sent.
   void OnStartWorkerMessageSent();
 
   // Called back from Registry when the worker instance has ack'ed that
   // it is ready for inspection.
   void OnReadyForInspection();
 
   // Called back from Registry when the worker instance has ack'ed that
   // it finished loading the script.
   void OnScriptLoaded();
@@ skipping 59 matching lines @@
 
   base::WeakPtr<ServiceWorkerContextCore> context_;
   scoped_refptr<EmbeddedWorkerRegistry> registry_;
 
   // Unique within an EmbeddedWorkerRegistry.
   const int embedded_worker_id_;
 
   EmbeddedWorkerStatus status_;
   StartingPhase starting_phase_;
 
   // Current running information.

[falken, 2016/09/07 05:01:42]

This comment doesn't seem to fit the members on line 313-315, which seem to have
longer lifetimes than between start and stop. Can you separate them from 311-312
with whitespace and even better add individual comments for them?

[shimazu, 2016/09/12 06:28:19]

Done.

   std::unique_ptr<EmbeddedWorkerInstance::WorkerProcessHandle> process_handle_;
   int thread_id_;
   std::unique_ptr<shell::InterfaceRegistry> interface_registry_;
   std::unique_ptr<shell::InterfaceProvider> remote_interfaces_;
+  mojom::EmbeddedWorkerInstanceClientPtr instance_client_;

[falken, 2016/09/07 05:01:41]

nit: Since this is a member of EmbeddedWorkerInstance, it seems it could be more
concisely named "client_".

[shimazu, 2016/09/12 06:28:19]

Done.

 
   // Whether devtools is attached or not.
   bool devtools_attached_;
 
   // True if the script load request accessed the network. If the script was
   // served from HTTPCache or ServiceWorkerDatabase this value is false.
   bool network_accessed_for_script_;
 
   ListenerList listener_list_;
   std::unique_ptr<DevToolsProxy> devtools_proxy_;
 
   std::unique_ptr<StartTask> inflight_start_task_;
 
   // This is valid only after a process is allocated for the worker.
   ServiceWorkerMetrics::StartSituation start_situation_ =
       ServiceWorkerMetrics::StartSituation::UNKNOWN;
 
   // Used for UMA. The start time of the current start sequence step.
   base::TimeTicks step_time_;
 
   base::WeakPtrFactory<EmbeddedWorkerInstance> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(EmbeddedWorkerInstance);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_EMBEDDED_WORKER_INSTANCE_H_